Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754640Ab2J1DAi (ORCPT ); Sat, 27 Oct 2012 23:00:38 -0400 Received: from glenfiddich.mraw.org ([88.191.124.82]:51980 "EHLO glenfiddich.mraw.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751231Ab2J1DAh (ORCPT ); Sat, 27 Oct 2012 23:00:37 -0400 X-Greylist: delayed 805 seconds by postgrey-1.27 at vger.kernel.org; Sat, 27 Oct 2012 23:00:37 EDT From: Cyril Brulebois To: nic_swsd@realtek.com, romieu@fr.zoreil.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Cyril Brulebois Subject: [PATCH] r8169: Fix WoL on RTL8168d/8111d. Date: Sun, 28 Oct 2012 03:46:54 +0100 Message-Id: <1351392414-32219-1-git-send-email-kibi@debian.org> X-Mailer: git-send-email 1.7.10.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1683 Lines: 46 This regression was spotted between Debian squeeze and Debian wheezy kernels (respectively based on 2.6.32 and 3.2). The fix was inspired by , using RTL_GIGA_MAC_VER_{25,26} for the RTL8168d/8111d chipset. Probable regression from d4ed95d796e5126bba51466dc07e287cebc8bd19; more chipsets are likely affected. Tested on top of a 3.2.23 kernel. Reported-by: Florent Fourcot Tested-by: Florent Fourcot Signed-off-by: Cyril Brulebois --- drivers/net/ethernet/realtek/r8169.c | 2 ++ 1 file changed, 2 insertions(+) It looks like RTL_GIGA_MAC_VER_{25,26} are kinda supposed to go together so I kept both. Florent's testing gave the following results: - RTL_GIGA_MAC_VER_25 only: FAIL. - RTL_GIGA_MAC_VER_26 only: SUCCESS. - RTL_GIGA_MAC_VER_25 + RTL_GIGA_MAC_VER_26: SUCCESS. diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index e7ff886..eb6a5e4 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -3827,6 +3827,8 @@ static void rtl_wol_suspend_quirk(struct rtl8169_private *tp) void __iomem *ioaddr = tp->mmio_addr; switch (tp->mac_version) { + case RTL_GIGA_MAC_VER_25: + case RTL_GIGA_MAC_VER_26: case RTL_GIGA_MAC_VER_29: case RTL_GIGA_MAC_VER_30: case RTL_GIGA_MAC_VER_32: -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/