Message-ID: <1351431201.8685.22.camel@maggy.simpson.net>
Subject: Re: [PATCH] sched, autogroup: fix crash on reboot when autogroup is
 disabled
From: Mike Galbraith <efault@gmx.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: Xiaotian Feng <xtfeng@gmail.com>, Peter Zijlstra <peterz@infradead.org>,
        linux-kernel@vger.kernel.org, Xiaotian Feng <dannyfeng@tencent.com>,
        Ingo Molnar <mingo@redhat.com>
Date: Sun, 28 Oct 2012 06:33:21 -0700
In-Reply-To: <20121028131950.GA15159@gmail.com>
References: <1350635770-9189-1-git-send-email-xtfeng@gmail.com>
	 <1350654126.2768.5.camel@twins>
	 <CAJn8CcE5McFB-FH981Pj+eahNOt8ck3ncJwD4xocU_LrAtjBHA@mail.gmail.com>
	 <1350736696.5123.24.camel@maggy.simpson.net>
	 <1351283371.16639.111.camel@maggy.simpson.net>
	 <1351362370.4503.3.camel@maggy.simpson.net>
	 <20121028102520.GA7711@gmail.com>
	 <1351430004.8685.17.camel@maggy.simpson.net>
	 <20121028131950.GA15159@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2088
Lines: 53

On Sun, 2012-10-28 at 14:19 +0100, Ingo Molnar wrote: 
> * Mike Galbraith <efault@gmx.de> wrote:
> 
> > On Sun, 2012-10-28 at 11:25 +0100, Ingo Molnar wrote: 
> > > * Mike Galbraith <efault@gmx.de> wrote:
> > > 
> > 
> > > > No knobs, no glitz, nada, just a cute little thing folks can turn
> > > > on if they don't want to muck about with cgroups and/or systemd.
> > > 
> > > Please also keep the Kconfig switch and reuse it to turn on 
> > > the 'autogroups' knob.
> > > 
> > > That way people with existing .config's don't have to change 
> > > a thing to get this functionality.
> > 
> > The Kconfig option is still there.  The noautogroup -> 
> > autogroup arg change just makes it off by default (since an 
> > on/off switch would have to be a full move everybody thing 
> > post 8323f26ce race fix), so distros can make it available in 
> > their swiss army knife config, but it'll be out of the way 
> > unless specifically asked for by the user at boot.
> > 
> > I can make it default 'on' by removing that arg change if you 
> > think that's the better way to go, but opt in at boot sounded 
> > better to me given there is no runtime on/off switch at all 
> > now.
> 
> If I got your patch right then adding a command line option to 
> turn it on will disable it in essence for pretty much everyone 
> who has CONFIG_SCHED_AUTOGROUP=y in their .config today.

With no user intervention, yes.

> The patch should not change the defaults for existing .config's. 
> 
> I.e. if autogroups was off, it should stay off, but if 
> autogroups was enabled in the .config and the kernel booted with 
> it enabled, then it should continue to do so in the future as 
> well.
> 
> Adding a boot tweak and removing the runtime knobs is OK - 
> changing the current default functionality is not.

Ok, I'll whack the arg change and respin.

-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/