Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752692Ab2J1Nh0 (ORCPT ); Sun, 28 Oct 2012 09:37:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31972 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752464Ab2J1NhZ (ORCPT ); Sun, 28 Oct 2012 09:37:25 -0400 Date: Sun, 28 Oct 2012 11:37:02 -0200 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: linux-kernel@vger.kernel.org, Corey Ashford , Frederic Weisbecker , Ingo Molnar , Namhyung Kim , Paul Mackerras , Peter Zijlstra Subject: Re: [PATCH 5/5] perf tool: Move dso_* related functions into dso object Message-ID: <20121028133702.GA6754@infradead.org> References: <1351372712-21104-1-git-send-email-jolsa@redhat.com> <1351372712-21104-6-git-send-email-jolsa@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1351372712-21104-6-git-send-email-jolsa@redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2547 Lines: 46 Em Sat, Oct 27, 2012 at 11:18:32PM +0200, Jiri Olsa escreveu: > Moving dso_* related functions into dso object. > > Keeping symbol loading related functions still in the symbol > object as it seems more convenient. Please resubmit after you fix this: The other 4 patches I already applied to my local tree. - Arnaldo CC /home/acme/git/build/perf/util/dso-test-data.o In file included from util/dso.c:2: util/dso.h:87: error: ‘BUILD_ID_SIZE’ undeclared here (not in a function) CC /home/acme/git/build/perf/util/color.o cc1: warnings being treated as errors util/dso.c: In function ‘dso__binary_type_file’: util/dso.c:45: error: implicit declaration of function ‘filename__read_debuglink’ util/dso.c:45: error: nested extern declaration of ‘filename__read_debuglink’ util/dso.c:51: error: ‘symbol_conf’ undeclared (first use in this function) util/dso.c:51: error: (Each undeclared identifier is reported only once util/dso.c:51: error: for each function it appears in.) util/dso.c: In function ‘dso__delete’: util/dso.c:435: error: implicit declaration of function ‘symbols__delete’ util/dso.c:435: error: nested extern declaration of ‘symbols__delete’ util/dso.c: In function ‘dso__read_running_kernel_build_id’: util/dso.c:462: error: implicit declaration of function ‘sysfs__read_build_id’ util/dso.c:462: error: nested extern declaration of ‘sysfs__read_build_id’ util/dso.c: In function ‘__dsos__read_build_ids’: util/dso.c:500: error: implicit declaration of function ‘filename__read_build_id’ util/dso.c:500: error: nested extern declaration of ‘filename__read_build_id’ util/dso.c: In function ‘dso__fprintf’: util/dso.c:589: error: dereferencing pointer to incomplete type util/dso.c:589: error: type defaults to ‘int’ in declaration of ‘__mptr’ util/dso.c:589: error: initialization from incompatible pointer type util/dso.c:589: error: invalid use of undefined type ‘struct symbol’ util/dso.c:590: error: implicit declaration of function ‘symbol__fprintf’ util/dso.c:590: error: nested extern declaration of ‘symbol__fprintf’ make: *** [/home/acme/git/build/perf/util/dso.o] Error 1 make: *** Waiting for unfinished jobs.... make: Leaving directory `/home/git/linux/tools/perf' [acme@sandy linux]$ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/