Date: Mon, 29 Oct 2012 08:40:55 +0100 (CET)
From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
cc: linux-kernel@vger.kernel.org
Subject: Re: [Q] .readable_reg() not verified during read?
In-Reply-To: <20121028180629.GB4547@opensource.wolfsonmicro.com>
Message-ID: <Pine.LNX.4.64.1210290833440.17869@axis700.grange>
References: <Pine.LNX.4.64.1210280034310.4378@axis700.grange>
 <20121028180629.GB4547@opensource.wolfsonmicro.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 993
Lines: 26

On Sun, 28 Oct 2012, Mark Brown wrote:

> On Sun, Oct 28, 2012 at 12:36:40AM +0200, Guennadi Liakhovetski wrote:
> 
> > Looking at regmap.c it looks like the .readable_reg() callback is not 
> > consulted when performing a register read, e.g. in _regmap_raw_read(). Is 
> > this intentional? If yes - why?
> 
> No real reason, though to be honest it's not that important - the main
> reason for having the function is to make the debugfs stuff work nicely
> rather than anything else.

But what about initialising the register cache in regcache_hw_init()? 
Doesn't it read in all registers without checking their readability?

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/