Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758178Ab2J2IvK (ORCPT ); Mon, 29 Oct 2012 04:51:10 -0400 Received: from LGEMRELSE7Q.lge.com ([156.147.1.151]:55060 "EHLO LGEMRELSE7Q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757817Ab2J2IvH (ORCPT ); Mon, 29 Oct 2012 04:51:07 -0400 X-AuditID: 9c930197-b7c4aae000004160-fd-508e4377568b From: Minchan Kim To: Greg Kroah-Hartman Cc: Andrew Morton , Nitin Gupta , Konrad Rzeszutek Wilk , Seth Jennings , Jens Axboe , Dan Magenheimer , Pekka Enberg , gaowanlong@cn.fujitsu.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Minchan Kim Subject: [PATCH v3 0/3] zram/zsmalloc promotion Date: Mon, 29 Oct 2012 17:56:46 +0900 Message-Id: <1351501009-15111-1-git-send-email-minchan@kernel.org> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4644 Lines: 110 This patchset promotes zram/zsmalloc from staging. Both are very clean and zram have been used by many embedded product for a long time. It's time to go out of staging. Greg, Jens is already OK that zram is located under driver/blocks/. The issue remained is where we put zsmalloc. The candidate is two under mm/ or under lib/ Konrad and Nitin wanted to put zsmalloc into lib/ instead of mm/. Quote from Nitin " I think mm/ directory should only contain the code which is intended for global use such as the slab allocator, page reclaim code etc. zsmalloc is used by only one (or possibly two) drivers, so lib/ seems to be the right place. " Quote from Konrand " I like the idea of keeping it in /lib or /mm. Actually 'lib' sounds more appropriate since it is dealing with storing a bunch of pages in a nice layout for great density purposes. " In fact, there is some history about that. Why I put zsmalloc into under mm firstly was that Andrew had a concern about using strut page's some fields freely in zsmalloc so he wanted to maintain it in mm/ if I remember correctly. So I and Nitin tried to ask the opinion to akpm several times (at least 6 and even I sent such patch a few month ago) but didn't get any reply from him so I guess he doesn't have any concern about that any more. In point of view that it's an another slab-like allocator, it might be proper under mm but it's not popular as current mm's allocators(/SLUB/SLOB and page allocator). Frankly speaking, I don't care whether we put it to mm/ or lib/. It seems contributors(ex, Nitin and Konrad) like lib/ and Andrew is still silent. That's why I am biased into lib/ now. If someone yell we should keep it to mm/ by logical claim, I can change my mind easily. Please raise your hand. If Andrew doesn't have a concern about that any more, I would like to locate it into /lib. This patchset is based on next-20121029 Minchan Kim (3): zsmalloc: promote to lib/ zram: promote zram from staging zram: select ZSMALLOC when ZRAM is configured drivers/block/Kconfig | 1 + drivers/block/Makefile | 1 + drivers/block/zram/Kconfig | 26 + drivers/block/zram/Makefile | 3 + drivers/block/zram/zram.txt | 76 +++ drivers/block/zram/zram_drv.c | 793 ++++++++++++++++++++++ drivers/block/zram/zram_drv.h | 119 ++++ drivers/block/zram/zram_sysfs.c | 225 +++++++ drivers/staging/Kconfig | 4 - drivers/staging/Makefile | 1 - drivers/staging/zcache/zcache-main.c | 4 +- drivers/staging/zram/Kconfig | 25 - drivers/staging/zram/Makefile | 3 - drivers/staging/zram/zram.txt | 76 --- drivers/staging/zram/zram_drv.c | 793 ---------------------- drivers/staging/zram/zram_drv.h | 120 ---- drivers/staging/zram/zram_sysfs.c | 225 ------- drivers/staging/zsmalloc/Kconfig | 10 - drivers/staging/zsmalloc/Makefile | 3 - drivers/staging/zsmalloc/zsmalloc-main.c | 1064 ------------------------------ drivers/staging/zsmalloc/zsmalloc.h | 43 -- include/linux/zsmalloc.h | 43 ++ lib/Kconfig | 18 + lib/Makefile | 1 + lib/zsmalloc.c | 1064 ++++++++++++++++++++++++++++++ 25 files changed, 2372 insertions(+), 2369 deletions(-) create mode 100644 drivers/block/zram/Kconfig create mode 100644 drivers/block/zram/Makefile create mode 100644 drivers/block/zram/zram.txt create mode 100644 drivers/block/zram/zram_drv.c create mode 100644 drivers/block/zram/zram_drv.h create mode 100644 drivers/block/zram/zram_sysfs.c delete mode 100644 drivers/staging/zram/Kconfig delete mode 100644 drivers/staging/zram/Makefile delete mode 100644 drivers/staging/zram/zram.txt delete mode 100644 drivers/staging/zram/zram_drv.c delete mode 100644 drivers/staging/zram/zram_drv.h delete mode 100644 drivers/staging/zram/zram_sysfs.c delete mode 100644 drivers/staging/zsmalloc/Kconfig delete mode 100644 drivers/staging/zsmalloc/Makefile delete mode 100644 drivers/staging/zsmalloc/zsmalloc-main.c delete mode 100644 drivers/staging/zsmalloc/zsmalloc.h create mode 100644 include/linux/zsmalloc.h create mode 100644 lib/zsmalloc.c -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/