Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760814Ab2J2UlQ (ORCPT ); Mon, 29 Oct 2012 16:41:16 -0400 Received: from usindpps06.hds.com ([207.126.252.19]:37489 "EHLO usindpps06.hds.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760634Ab2J2UlO convert rfc822-to-8bit (ORCPT ); Mon, 29 Oct 2012 16:41:14 -0400 From: Seiji Aguchi To: Mike Waychison CC: "linux-kernel@vger.kernel.org" , "linux-efi@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "Luck, Tony (tony.luck@intel.com)" , "Matthew Garrett (mjg@redhat.com)" , "dzickus@redhat.com" , "dle-develop@lists.sourceforge.net" , Satoru Moriya Subject: RE: [PATCH v3 7/7] Add a format check for an existing variable name at erasing time Thread-Topic: [PATCH v3 7/7] Add a format check for an existing variable name at erasing time Thread-Index: Ac2zwvFR+xYuXJbURSmiNIlI2zWcyQCcfmgAAAfYtmA= Date: Mon, 29 Oct 2012 20:40:59 +0000 Message-ID: References: In-Reply-To: Accept-Language: ja-JP, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.74.43.113] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.7.7855,1.0.431,0.0.0000 definitions=2012-10-29_03:2012-10-29,2012-10-29,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_policy_notspam policy=outbound_policy score=0 spamscore=0 ipscore=0 suspectscore=1 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=6.0.2-1203120001 definitions=main-1210290243 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1060 Lines: 22 > > + utf16_strlen(efi_name))) { > > + /* > > + * Check if an old format, > > + * which doesn't support holding > > + * multiple logs, remains. > > + */ > > + if (sscanf(name, "dump-type%u-%u-%lu", > > + &type_old, &part_old, &time_old) != > > + 3) > > This doesn't look right. This should probably mirror the sprintf() at the top of the function using a new string, convert it to 16-bit > Unicodeand then compare it like we do for the 4-variable version above (please ignore the fact that this driver incorrectly calls these > strings utf16 everywhere -- that needs to be fixed). I will fix it as well. Seiji -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/