Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761006Ab2J2VeS (ORCPT ); Mon, 29 Oct 2012 17:34:18 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52431 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751861Ab2J2VeQ (ORCPT ); Mon, 29 Oct 2012 17:34:16 -0400 Date: Mon, 29 Oct 2012 22:34:12 +0100 From: Michal Hocko To: David Rientjes Cc: Lai Jiangshan , Mel Gorman , LKML , x86 maintainers , Jiang Liu , Rusty Russell , Yinghai Lu , KAMEZAWA Hiroyuki , Yasuaki ISIMATU , Andrew Morton , Johannes Weiner , Balbir Singh , Tejun Heo , Li Zefan , cgroups@vger.kernel.org, linux-mm@kvack.org, containers@lists.linux-foundation.org Subject: Re: [V5 PATCH 08/26] memcontrol: use N_MEMORY instead N_HIGH_MEMORY Message-ID: <20121029213412.GC21640@dhcp22.suse.cz> References: <1351523301-20048-1-git-send-email-laijs@cn.fujitsu.com> <1351524078-20363-7-git-send-email-laijs@cn.fujitsu.com> <20121029162212.GE20757@dhcp22.suse.cz> <20121029205806.GB21640@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1620 Lines: 46 On Mon 29-10-12 14:08:05, David Rientjes wrote: > On Mon, 29 Oct 2012, Michal Hocko wrote: > > > > > > N_HIGH_MEMORY stands for the nodes that has normal or high memory. > > > > > N_MEMORY stands for the nodes that has any memory. > > > > > > > > What is the difference of those two? > > > > > > > > > > Patch 5 in the series > > > > Strange, I do not see that one at the mailing list. > > > > http://marc.info/?l=linux-kernel&m=135152595827692 Thanks! > > > introduces it to be equal to N_HIGH_MEMORY, so > > > > So this is just a rename? If yes it would be much esier if it was > > mentioned in the patch description. > > > > It's not even a rename even though it should be, it's adding yet another > node_states that is equal to N_HIGH_MEMORY since that state already > includes all memory. Which is really strange because I do not see any reason for yet another alias if the follow up patches rename all of them (I didn't try to apply the whole series to check that so I might be wrong here). > It's just a matter of taste but I think we should be renaming it > instead of aliasing it (unless you actually want to make N_HIGH_MEMORY > only include nodes with highmem, but nothing depends on that). Agreed, I've always considered N_HIGH_MEMORY misleading and confusing so renaming it would really make a lot of sense to me. -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/