Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933252Ab2J2Vpx (ORCPT ); Mon, 29 Oct 2012 17:45:53 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:55739 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933095Ab2J2Vpt (ORCPT ); Mon, 29 Oct 2012 17:45:49 -0400 MIME-Version: 1.0 In-Reply-To: <1351504796-24788-5-git-send-email-b.zolnierkie@samsung.com> References: <1351504796-24788-1-git-send-email-b.zolnierkie@samsung.com> <1351504796-24788-5-git-send-email-b.zolnierkie@samsung.com> Date: Mon, 29 Oct 2012 22:45:48 +0100 Message-ID: Subject: Re: [PATCH 4/4] DMA: PL330: add device tree property for DMA_MEMCPY capability From: Jassi Brar To: Bartlomiej Zolnierkiewicz Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, vinod.koul@intel.com, kgene.kim@samsung.com, rob.herring@calxeda.com, dinguyen@altera.com, pawel.moll@arm.com, t.figa@samsung.com, kyungmin.park@samsung.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 830 Lines: 16 On Mon, Oct 29, 2012 at 10:59 AM, Bartlomiej Zolnierkiewicz wrote: > * Add device tree (DT) property ("pl330,dma-memcpy") for DMA_MEMCPY > capability and instead of setting this capability unconditionally > in pl330_probe() do it only when property is present. > Perhaps we should pass the array of peripheral interfaces via DT, the lack of which could imply MEMCPY capability ? (while it works, I doubt if pl330 is supposed to have SLAVE and MEMCPY capabilities in any instance) That would also be a step towards discarding "struct dma_pl330_platdata". -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/