Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933297Ab2J2VsO (ORCPT ); Mon, 29 Oct 2012 17:48:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46186 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933040Ab2J2VsF (ORCPT ); Mon, 29 Oct 2012 17:48:05 -0400 From: Naoya Horiguchi To: Andi Kleen Cc: Dave Chinner , Tony Luck , Naoya Horiguchi , Andi Kleen , Wu Fengguang , Andrew Morton , Jan Kara , "Jun'ichi Nomura" , Akira Fujita , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH 2/3] ext4: introduce ext4_error_remove_page Date: Mon, 29 Oct 2012 17:47:36 -0400 Message-Id: <1351547256-837-1-git-send-email-n-horiguchi@ah.jp.nec.com> In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 946 Lines: 25 On Mon, Oct 29, 2012 at 12:07:04PM -0700, Andi Kleen wrote: > Theodore Ts'o writes: ... > > Also, if you're going to keep this state in memory, what happens if > > the inode gets pushed out of memory? > > You lose the error, just like you do today with any other IO error. > > We had a lot of discussions on this when the memory error handling > was originally introduced, that was the conclusuion. > > I don't think a special panic knob for this makes sense either. > We already have multiple panic knobs for memory errors, that > can be used. Yes. I understand that adding a new knob is not good. So this patch uses the existing ext4 knob without adding new one. Thanks, Naoya -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/