Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753586Ab2J3Cra (ORCPT ); Mon, 29 Oct 2012 22:47:30 -0400 Received: from userp1050.oracle.com ([156.151.31.82]:33254 "EHLO userp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752753Ab2J3Cr2 (ORCPT ); Mon, 29 Oct 2012 22:47:28 -0400 From: Zheng Li To: netdev@vger.kernel.org, fubar@us.ibm.com, andy@greyhouse.net Cc: linux-kernel@vger.kernel.org, davem@davemloft.net, joe.jin@oracle.com, zheng.x.li@oracle.com Subject: [PATCH] bonding: fix bond 6 mode change MAC of arp reply from vif to cause Domu's network unreachable intermittently Date: Tue, 30 Oct 2012 10:47:51 +0800 Message-Id: <1351565271-5888-1-git-send-email-zheng.x.li@oracle.com> X-Mailer: git-send-email 1.7.6.5 X-Source-IP: userp1040.oracle.com [156.151.31.81] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2191 Lines: 54 This is a fix for a bug in bond_alb.c Rate of reproduced:100% Scenario: set Dom0 to bond 6 mode, Domu communicate with Dom0 through vif which is in bridge mode. The Dom0's bridge of xenbr0 contains vif and bond0, bond0 contains eth0 and eth1. You can just need to ping a host which is in same LAN on Domu, some of packets will be lost intermittently. Analyse: When Dom0 set bond mode to 6, the bond alb will change MAC of every arp reply in rlb_arp_xmit function to affect receive packets, it is ok for normal NIC, but it's wrong to Domu, when Domu send arp reply through vif of Dom0, bond of alb replace Domu's MAC in arp reply with NIC's MAC address, that will cause remote host send packets to Domu using real NIC's MAC instead of Domu's MAC. Domu can't receive the packets whose dst MAC is not Domu's MAC. Cc: Jay Vosburgh Cc: Andy Gospodarek Cc: "David S. Miller" Signed-off-by: Zheng Li --- drivers/net/bonding/bond_alb.c | 13 ++++++++++++- 1 files changed, 12 insertions(+), 1 deletions(-) diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c index e15cc11..d6b134a 100644 --- a/drivers/net/bonding/bond_alb.c +++ b/drivers/net/bonding/bond_alb.c @@ -700,7 +700,18 @@ static struct slave *rlb_arp_xmit(struct sk_buff *skb, struct bonding *bond) */ tx_slave = rlb_choose_channel(skb, bond); if (tx_slave) { - memcpy(arp->mac_src,tx_slave->dev->dev_addr, ETH_ALEN); + struct slave *tmp_slave = NULL; + int i = 0, found_mac = 0; + bond_for_each_slave(bond, tmp_slave, i) { + if (ether_addr_equal_64bits(arp->mac_src, + tmp_slave->dev->dev_addr)) { + found_mac = 1; + break; + } + } + if (found_mac) + memcpy(arp->mac_src, tx_slave->dev->dev_addr, + ETH_ALEN); } pr_debug("Server sent ARP Reply packet\n"); } else if (arp->op_code == htons(ARPOP_REQUEST)) { -- 1.7.6.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/