Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756912Ab2J3JNn (ORCPT ); Tue, 30 Oct 2012 05:13:43 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:34659 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751903Ab2J3JNk (ORCPT ); Tue, 30 Oct 2012 05:13:40 -0400 Message-ID: <508F9A3E.9020105@ti.com> Date: Tue, 30 Oct 2012 10:13:34 +0100 From: "Cousson, Benoit" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20120907 Thunderbird/15.0.1 MIME-Version: 1.0 To: Sourav CC: , , , Felipe Balbi , Santosh Shilimkar Subject: Re: [RESEND/PATCHv3] arm: dts: omap5-evm: Add keypad support References: <1351507226-10328-1-git-send-email-sourav.poddar@ti.com> <508EB250.20607@ti.com> <508F64EC.9000809@ti.com> In-Reply-To: <508F64EC.9000809@ti.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2287 Lines: 72 Hi Sourav, On 10/30/2012 6:26 AM, Sourav wrote: > Hi Benoit, > On Monday 29 October 2012 10:14 PM, Benoit Cousson wrote: >> Hi Sourav, >> >> On 10/29/2012 11:40 AM, Sourav Poddar wrote: >>> Add keypad data node in omap5-evm. >>> >>> Based on I2C support patch for omap5, which has been >>> already posted as a different series. >>> >>> Tested on omap5430 evm with 3.7-rc1 kernel. >>> >>> Cc: Felipe Balbi >>> Cc: Santosh Shilimkar >>> >>> Tested on omap5430 sdp with 3.7-rc1 kernel. >>> >>> Signed-off-by: Sourav Poddar >>> --- >>> arch/arm/boot/dts/omap5-evm.dts | 95 >>> +++++++++++++++++++++++++++++++++++++++ >>> 1 files changed, 95 insertions(+), 0 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/omap5-evm.dts >>> b/arch/arm/boot/dts/omap5-evm.dts >>> index c663eba..b812d6d 100644 >>> --- a/arch/arm/boot/dts/omap5-evm.dts >>> +++ b/arch/arm/boot/dts/omap5-evm.dts >>> @@ -140,3 +140,98 @@ >>> &mcbsp3 { >>> status = "disabled"; >>> }; >>> + >>> +&i2c5 { >>> + clock-frequency = <400000>; >>> + >>> + smsc@38 { >>> + compatible = "smscece1099"; >>> + reg = <0x38>; >>> + clock = <0x13>; >> What does that "clock" mean? > This chip supports a clock control register which is used to enable the > interface used by the chip to communicate. Here, the interface which you > can are > SMBUS interface or BC-LINK interface. OK, so you should use a less generic name than "clock" and potentially prefix it with "smsc," since it is not a generic attribute at all. BTW, cannot we use the CCF in order to control that clock? I guess it is just a clock mux? Well, anyway we need CCF for OMAP to be merged first :-) But it might worth highlighting this is a temporary solution. >> I cannot find that in the binding documentation. BTW, did you add that >> documentation in the driver patch? > Nope, I missed out on the dt binding documentation for the driver. :( > > Will send a seperate patch for the bindings. Thanks, Benoit -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/