Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753877Ab2J3Nty (ORCPT ); Tue, 30 Oct 2012 09:49:54 -0400 Received: from mail-qa0-f46.google.com ([209.85.216.46]:65351 "EHLO mail-qa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753004Ab2J3Ntw (ORCPT ); Tue, 30 Oct 2012 09:49:52 -0400 Date: Tue, 30 Oct 2012 09:37:22 -0400 From: Konrad Rzeszutek Wilk To: "Liu, Jinsong" Cc: Konrad Rzeszutek Wilk , "linux-kernel@vger.kernel.org" , Jan Beulich , "xen-devel@lists.xen.org" Subject: Re: [Xen-devel] [PATCH 1/2] Xen acpi pad implement Message-ID: <20121030133720.GA27463@phenom.dumpdata.com> References: <5089676602000078000A4928@nat28.tlf.novell.com> <508A89CB020000780008E6ED@nat28.tlf.novell.com> <20121026201409.GF2708@phenom.dumpdata.com> <20121029123950.GK2708@phenom.dumpdata.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1232 Lines: 26 > > +config XEN_ACPI_PAD_STUB > > + bool > > + depends on XEN_DOM0 && X86_64 && ACPI > > + default n > > + > > This Kconfig is pointless, if CONFIG_XEN_ACPI_PAD_STUB = n, native pad would successfully registerred, and then mwait #UD (we would revert df88b2d96e36d9a9e325bfcd12eb45671cbbc937, right?). So xen stub logic should unconditionally built-in kernel. Potentially. Keep in mind that there is no need to built this if the kernel is not built with ACPI. .. snip. > > +subsys_initcall(xen_acpi_pad_stub_init); > > I'm still confused. In this way there are xen-acpi-pad-stub.c and xen-acpi-pad.c, and you want to let xen-acpi-pad loaded as module, right? how can xen-acpi-pad logic work when it was insmoded? Via the register/unregister calls that this provides? Or does ACPI bus drivers get immediately called once the call acpi_bus_register_driver? Or can one 'poke' the 'add' and 'remove' calls so that once the "true" PAD driver is loaded it will restart the ops->add call? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/