Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934558Ab2J3VCT (ORCPT ); Tue, 30 Oct 2012 17:02:19 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:59565 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934175Ab2J3VCR (ORCPT ); Tue, 30 Oct 2012 17:02:17 -0400 Date: Tue, 30 Oct 2012 14:02:13 -0700 From: Greg Kroah-Hartman To: Tony Lindgren Cc: Omar Ramirez Luna , Ohad Ben-Cohen , devel@driverdev.osuosl.org, linux-omap@vger.kernel.org, Russell King , Arnd Bergmann , Juan Gutierrez , linux-kernel@vger.kernel.org, Felipe Contreras , Suman Anna , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] ARM: OMAP2+: move mailbox.h out of plat-omap headers Message-ID: <20121030210213.GA6098@kroah.com> References: <1351530381-11459-1-git-send-email-omar.luna@linaro.org> <1351530381-11459-2-git-send-email-omar.luna@linaro.org> <20121029175228.GD11908@atomide.com> <20121030162441.GF11908@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121030162441.GF11908@atomide.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1954 Lines: 52 On Tue, Oct 30, 2012 at 09:24:42AM -0700, Tony Lindgren wrote: > * Omar Ramirez Luna [121030 05:20]: > > Tony, > > > > On 29 October 2012 12:52, Tony Lindgren wrote: > > >> --- /dev/null > > >> +++ b/include/linux/platform_data/omap_mailbox.h > > >> @@ -0,0 +1,105 @@ > > > > > > This file should only contain pure platform data needed > > > by the core omap code to pass to the mailbox driver. > > > > Ok, looking at it closely, this header file is related to the API > > itself, there is nothing that could be actually considered as pure > > platform data, the structures are related with the mailbox framework > > and even if I split this file into two, the additional header would > > end up including the "platform_data" header unless I move > > save/restore_ctx functions and then export them as symbols for the > > API. > > > > So, it might be better for the entire file to sit in > > linux/include/mailbox/ then. > > OK to me. > > > > The mailbox API header should be somewhere else, > > > like include/linux/mailbox/mailbox-omap.h or similar. > > > > Ok. > > > > > But shouldn't this all now be handled by using the > > > remoteproc framework? > > > > Remoteproc doesn't handle the mailbox hardware directly, it still > > relies in the mailbox framework for the low level communications. > > E.g.: Proc1 has a message (virtqueue msg) queued to Proc2, uses > > mailbox msg to generate an interrupt to Proc2, Proc2 queries the > > message (virtqueue) based on the mailbox message received. > > OK. > > Greg, do these patches look OK to you to move to live under > drivers/mailbox? Um, I don't know, I wasn't paying attention here, sorry. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/