Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752040Ab2JaFJl (ORCPT ); Wed, 31 Oct 2012 01:09:41 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:40407 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750884Ab2JaFJi convert rfc822-to-8bit (ORCPT ); Wed, 31 Oct 2012 01:09:38 -0400 From: "Hiremath, Vaibhav" To: Paul Walmsley , Tony Lindgren CC: Pantelis Antoniou , "linux-omap@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Koen Kooi , "Porter, Matt" , "Dill, Russ" , "linux-fbdev@vger.kernel.org" Subject: RE: [PATCH] omap2-clk: Add missing lcdc clock definition Thread-Topic: [PATCH] omap2-clk: Add missing lcdc clock definition Thread-Index: AQHNtvYG6t4YD4tdv0iN86NxZoH7IpfS0m0g Date: Wed, 31 Oct 2012 05:09:31 +0000 Message-ID: <79CD15C6BA57404B839C016229A409A83EB529E4@DBDE01.ent.ti.com> References: <1351698962-3923-1-git-send-email-panto@antoniou-consulting.com> <20121030181837.GM11908@atomide.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.24.133.105] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1581 Lines: 51 On Wed, Oct 31, 2012 at 04:56:40, Paul Walmsley wrote: > + Vaibhav Hiremath > > On Tue, 30 Oct 2012, Tony Lindgren wrote: > > > * Pantelis Antoniou [121030 11:04]: > > > Looks like the lcdc clock definition got dropped. > > > It is required for the LCD controller to work. Reintroduce. > > > > This looks like a regression, can you also add the commit > > causing it? > > Looks like probably a new "feature," in that this clock didn't exist in > the original check-in. Would be good to get Vaibhav's opinion on this; > also the common clock patches will need to be updated. > Thanks Paul for looping me in, something went wrong with my l-o subscription, so I didn't receive these Patches. As far as lck clock node is concerned, we had deliberately dropped all leaf- node clocks from the clock tree, please refer to the description mentioned in - http://lists.infradead.org/pipermail/linux-arm-kernel/2012-May/101987.html >From LCDC driver perspective, driver is using, fb_clk = clk_get(&device->dev, NULL); This I feel needs to be corrected for valid name as per Spec (mostly I would vote for "fck") and then every platform should make sure that it returns valid clock-node for it. Change in Driver would be, fb_clk = clk_get(&device->dev, "fck"); Thanks, Vaibhav > > - Paul > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/