Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754270Ab2JaG4q (ORCPT ); Wed, 31 Oct 2012 02:56:46 -0400 Received: from mail-ea0-f174.google.com ([209.85.215.174]:44231 "EHLO mail-ea0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752096Ab2JaG4n (ORCPT ); Wed, 31 Oct 2012 02:56:43 -0400 MIME-Version: 1.0 In-Reply-To: <1350600107-4558-1-git-send-email-elezegarcia@gmail.com> References: <1350600107-4558-1-git-send-email-elezegarcia@gmail.com> Date: Wed, 31 Oct 2012 08:56:42 +0200 X-Google-Sender-Auth: D3QaxN42aPL3z5ryf_-SWaps5Sc Message-ID: Subject: Re: [PATCH 1/3] mm/slob: Drop usage of page->private for storing page-sized allocations From: Pekka Enberg To: Ezequiel Garcia Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Tim Bird Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 830 Lines: 17 On Fri, Oct 19, 2012 at 1:41 AM, Ezequiel Garcia wrote: > This field was being used to store size allocation so it could be > retrieved by ksize(). However, it is a bad practice to not mark a page > as a slab page and then use fields for special purposes. > There is no need to store the allocated size and > ksize() can simply return PAGE_SIZE << compound_order(page). > > Cc: Pekka Penberg > Acked-by: Christoph Lameter > Signed-off-by: Ezequiel Garcia Applied all three patches. Thanks, Ezequiel! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/