Date: Wed, 31 Oct 2012 08:29:36 +0100
Message-ID: <s5hfw4vt7z3.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 5/5] snd-ice1712: Fix resume on ice1724
In-Reply-To: <201210302034.00890.linux@rainbow-software.org>
References: <201210302034.00890.linux@rainbow-software.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1109
Lines: 30

At Tue, 30 Oct 2012 20:34:00 +0100,
Ondrej Zary wrote:
> 
> On Wednesday 17 October 2012 08:57:39 Takashi Iwai wrote:
> > At Sun, 14 Oct 2012 21:09:23 +0200,
> >
> > Ondrej Zary wrote:
> > > set_pro_rate() is called from hw_params() but not from prepare(),
> > > breaking running PCM on suspend/resume. Call it from prepare() if PCM was
> > > suspended to fix the problem.
> > >
> > > Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
> >
> > This should be fixed in the resume callback.  Could you check the
> > patch below instead?
> 
> I've now verified that this patch fixes a real problem. When "multi track rate 
> locking" is disabled and some sound is played at non-default (non-48kHz) 
> frequency during suspend, the frequency is wrong (48kHz) after resume. This 
> patch fixes that.

OK, the patch was applied now.  Thanks for checking.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/