Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935085Ab2JaIGG (ORCPT ); Wed, 31 Oct 2012 04:06:06 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:56674 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935002Ab2JaIFn (ORCPT ); Wed, 31 Oct 2012 04:05:43 -0400 From: Xiaotian Feng To: linux-kernel@vger.kernel.org Cc: Xiaotian Feng , Xiaotian Feng , Jon Maloy , Allan Stephens , "David S. Miller" , netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net Subject: [PATCH 3/3] tipc: do not use tasklet_disable before tasklet_kill Date: Wed, 31 Oct 2012 16:06:01 +0800 Message-Id: <1351670761-26749-3-git-send-email-xtfeng@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1351670761-26749-1-git-send-email-xtfeng@gmail.com> References: <1351670761-26749-1-git-send-email-xtfeng@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1017 Lines: 33 If tasklet_disable() is called before related tasklet handled, tasklet_kill will never be finished. tasklet_kill is enough. Signed-off-by: Xiaotian Feng Cc: Jon Maloy Cc: Allan Stephens Cc: "David S. Miller" Cc: netdev@vger.kernel.org Cc: tipc-discussion@lists.sourceforge.net --- net/tipc/handler.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/tipc/handler.c b/net/tipc/handler.c index 111ff83..b36f0fc 100644 --- a/net/tipc/handler.c +++ b/net/tipc/handler.c @@ -116,7 +116,6 @@ void tipc_handler_stop(void) return; handler_enabled = 0; - tasklet_disable(&tipc_tasklet); tasklet_kill(&tipc_tasklet); spin_lock_bh(&qitem_lock); -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/