Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757435Ab2JaMwY (ORCPT ); Wed, 31 Oct 2012 08:52:24 -0400 Received: from mail-we0-f174.google.com ([74.125.82.174]:61870 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756633Ab2JaMwW (ORCPT ); Wed, 31 Oct 2012 08:52:22 -0400 MIME-Version: 1.0 In-Reply-To: <20121030182420.GA17171@rei.Home> References: <20121030182420.GA17171@rei.Home> Date: Wed, 31 Oct 2012 20:52:21 +0800 Message-ID: Subject: Re: Partialy mapped page stays in page cache after unmap From: Bob Liu To: chrubis@suse.cz Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Hugh Dickins , Michel Lespinasse , Ingo Molnar , Al Viro , Andrew Morton Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1656 Lines: 43 On Wed, Oct 31, 2012 at 2:24 AM, wrote: > Hi! > I'm currently revisiting mmap related tests in LTP (Linux Test Project) > and I've came to the tests testing that writes to the partially > mapped page (at the end of mapping) are carried out correctly. > > These tests fails because even after the object is unmapped and the > file-descriptor closed the pages still stays in the page cache so if > (possibly another process) opens and maps the file again the whole > content of the partial page is preserved. > > Strictly speaking this is not a bug at least when sticking to regular > files as POSIX which says that the change is not written out. In this > case the file content is correct and forcing the data to be written out > by msync() makes the test pass. The SHM mappings seems to preserve the > content even after calling msync() which is, in my opinion, POSIX > violation although a minor one. > fsync implemented in SHM is noop_fsync. May be we should extend it if needed. > Looking at the test results I have, the file based mmap test worked fine > on 2.6.5 (or perhaps the page cache was working/setup differently and > the test succeeded by accidend). > > Attached is a stripped down LTP test for the problem, uncommenting the > msync() makes the test succeed. > > I would like to hear your opinions on this problems. > > -- > Cyril Hrubis > chrubis@suse.cz -- Regards, --Bob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/