Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759562Ab2JaSzf (ORCPT ); Wed, 31 Oct 2012 14:55:35 -0400 Received: from mail.skyhub.de ([78.46.96.112]:50361 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753081Ab2JaSzd (ORCPT ); Wed, 31 Oct 2012 14:55:33 -0400 Date: Wed, 31 Oct 2012 19:55:30 +0100 From: Borislav Petkov To: Daniel J Blueman Cc: Ingo Molnar , Thomas Gleixner , H Peter Anvin , Steffen Persvold , x86@kernel.org, linux-kernel@vger.kernel.org, Torsten Kaiser Subject: Re: [PATCH 2/4, v2] AMD64 EDAC: Add support for >255 memory controllers Message-ID: <20121031185530.GK24389@liondog.tnic> Mail-Followup-To: Borislav Petkov , Daniel J Blueman , Ingo Molnar , Thomas Gleixner , H Peter Anvin , Steffen Persvold , x86@kernel.org, linux-kernel@vger.kernel.org, Torsten Kaiser References: <1351662932-22279-2-git-send-email-daniel@numascale-asia.com> <1351673292-31359-1-git-send-email-daniel@numascale-asia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1351673292-31359-1-git-send-email-daniel@numascale-asia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1533 Lines: 44 On Wed, Oct 31, 2012 at 04:48:12PM +0800, Daniel J Blueman wrote: > As the AMD64 last-level-cache ID is 16-bits and federated systems > eg using Numascale's NumaConnect/NumaChip can have more than 255 memory > controllers, use 16-bits to store the ID. > > v2: Avoid change to intlv_en variable > > Signed-off-by: Daniel J Blueman > --- > drivers/edac/amd64_edac.c | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c > index 18d404a..28b2005 100644 > --- a/drivers/edac/amd64_edac.c > +++ b/drivers/edac/amd64_edac.c > @@ -942,7 +942,8 @@ static u64 get_error_address(struct mce *m) > struct amd64_pvt *pvt; > u64 cc6_base, tmp_addr; > u32 tmp; > - u8 mce_nid, intlv_en; > + u16 mce_nid; > + u8 intlv_en; > > if ((addr & GENMASK(24, 47)) >> 24 != 0x00fdf7) > return addr; > @@ -1499,7 +1500,7 @@ static int f1x_match_to_this_node(struct amd64_pvt *pvt, unsigned range, > u8 channel; > bool high_range = false; > > - u8 node_id = dram_dst_node(pvt, range); > + u16 node_id = dram_dst_node(pvt, range); No need for that change since the field dram_dst_node returns is 3 bits wide (see F1x4{0,4}). -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/