Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760393Ab2JaVdi (ORCPT ); Wed, 31 Oct 2012 17:33:38 -0400 Received: from terminus.zytor.com ([198.137.202.10]:32771 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755989Ab2JaVdg (ORCPT ); Wed, 31 Oct 2012 17:33:36 -0400 Message-ID: <5091991D.4020202@zytor.com> Date: Wed, 31 Oct 2012 14:33:17 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 MIME-Version: 1.0 To: Robert Richter CC: "Zhang, Jun" , Ingo Molnar , Thomas Gleixner , "x86@kernel.org" , "oprofile-list@lists.sf.net" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] Sometimes, there is OOPS happened when we use oprofile. References: <88DC34334CA3444C85D647DBFA962C270FD7E416@SHSMSX102.ccr.corp.intel.com> <20121031210522.GB4386@ivy.homofaber> In-Reply-To: <20121031210522.GB4386@ivy.homofaber> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1175 Lines: 40 On 10/31/2012 02:05 PM, Robert Richter wrote: > Jun, > > On 29.10.12 02:33:54, Zhang, Jun wrote: >> Sometimes, there is OOPS happened when we use oprofile. next >> is the call stack. From call stack, we find in >> call_on_stack if there is a nmi interrupt between "xchgl >> %%ebx,%%esp" and "call *%%edi", system will OOPS. > > this should be related and fixed with: > > https://lkml.org/lkml/2012/9/12/269 > > Ingo, HPA, > > please apply the fix of kernel_stack_pointer(). > I'm vaguely concerned about the following: + * To always return a non-null + * stack pointer we fall back to regs as stack if no previous stack + * exists. The logic being that if there is no stack pointer and the stack is too empty, to simply assume regs point to the top of the stack? Is this possible to ever be actually seen? -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/