Message-Id: <5092D31C020000780008EB6B@nat28.tlf.novell.com>
Date: Thu, 01 Nov 2012 19:53:00 +0000
From: "Jan Beulich" <jbeulich@suse.com>
To: <rostedt@goodmis.org>, <sqazi@google.com>
Cc: <peterz@infradead.org>, <tglx@linutronix.de>,
        <torvalds@linux-foundation.org>, <hpa@linux.intel.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [PATCH] x86: Don't clobber top of pt_regs in
 nested NMI
References: <20121002002919.27236.14388.stgit@dungbeetle.mtv.corp.google.com>
 <1351731872.4004.112.camel@gandalf.local.home>
In-Reply-To: <1351731872.4004.112.camel@gandalf.local.home>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1221
Lines: 38

>>> Steven Rostedt <rostedt@goodmis.org> 11/01/12 2:04 AM >>>
>On Mon, 2012-10-01 at 17:29 -0700, Salman Qazi wrote:
>> @@ -1826,12 +1832,15 @@ repeat_nmi:
>>       * is benign for the non-repeat case, where 1 was pushed just above
>>       * to this very stack slot).
>>       */
>> -    movq $1, 5*8(%rsp)
>> +    movq $1, 10*8(%rsp)
>>  
>>      /* Make another copy, this one may be modified by nested NMIs */
>> +    addq $(10*8), %rsp
>
>This breaks the CFI magic.
>
>>      .rept 5
>> -    pushq_cfi 4*8(%rsp)
>> +    pushq_cfi -6*8(%rsp)
>>      .endr
>> +    subq $(5*8), %rsp
>
>So does this.
>
>This needs to be annotated correctly before I can push it out. But the
>good news is, I stressed tested this change, and it all works out.
>
>Jan, can you help out here?

There doesn't appear to be anything special about these adjustments, so I
don't see what help would be required here - it ought to be the normal use
of CFI_ADJUST_CFA_OFFSET that needs adding.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/