2012-11-13 12:30:10

by David R

[permalink] [raw]
Subject: Sched - trivial spelling patch

Spell "logarithmic" correctly in sched debug.

--- kernel/sched/debug.c.orig 2012-11-13 11:52:59.000000000 +0000
+++ kernel/sched/debug.c 2012-11-13 11:53:30.000000000 +0000
@@ -318,7 +318,7 @@

static const char *sched_tunable_scaling_names[] = {
"none",
- "logaritmic",
+ "logarithmic",
"linear"
};


2012-11-13 13:13:14

by Richard Weinberger

[permalink] [raw]
Subject: Re: Sched - trivial spelling patch

On Tue, Nov 13, 2012 at 1:13 PM, David R <[email protected]> wrote:
> Spell "logarithmic" correctly in sched debug.
>
> --- kernel/sched/debug.c.orig 2012-11-13 11:52:59.000000000 +0000
> +++ kernel/sched/debug.c 2012-11-13 11:53:30.000000000 +0000
> @@ -318,7 +318,7 @@
>
> static const char *sched_tunable_scaling_names[] = {
> "none",
> - "logaritmic",
> + "logarithmic",
> "linear"
> };
>

Your patch is missing a Signed-off-by tag.
Please use checkpatch.pl to verify your patch.

On the other hand I'm not sure if this change is a good idea.
sched_tunable_scaling_names is exposed to user space,
changing a member may break existing applications.

--
Thanks,
//richard

2012-11-13 13:20:09

by David R

[permalink] [raw]
Subject: Re: Sched - trivial spelling patch

Quoting richard -rw- weinberger <[email protected]>:

> Your patch is missing a Signed-off-by tag.
> Please use checkpatch.pl to verify your patch.

I really didn't think it was significant enough to bother to be frank.

> On the other hand I'm not sure if this change is a good idea.
> sched_tunable_scaling_names is exposed to user space,
> changing a member may break existing applications.

I didn't notice that, it just irritates every time I look at
/proc/sched_debug. If it has to be it has to be :-)

Cheers
David