2002-09-18 07:04:52

by Ben Greear

[permalink] [raw]
Subject: Re: [PATCH] Networking: send-to-self [link to non-broken patch this time]

So, I feel bad about wasting bandwidth and spamming folks with busted patches.
The corrected patch(es) can be found here for those who are interested:



Ben Greear <[email protected]> <Ben_Greear AT excite.com>
President of Candela Technologies Inc http://www.candelatech.com
ScryMUD: http://scry.wanfear.com http://scry.wanfear.com/~greear

2002-09-18 22:59:45

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] Networking: send-to-self [link to non-broken patch this time]

From: Ben Greear <[email protected]>
Date: Wed, 18 Sep 2002 00:09:50 -0700


I don't think I'll be applying this:

1) No tcp ipv6 bits
2) SIOC{S,G}ACCEPTLOCALADDRS added, but no 32-bit translation
code added to varions 64-bit/32-bit biarch port ioctl handling.
Also, no code added to the ioctl dispatch in the networking
so that devices could actually receive these requests.
3) Finally, it's just too damn ugly. If you have to ifdef it then
it really doesn't belong in the tree. Maybe if the device number
comparison logic changes existed via macros in tcp.h and thus
removing all the CONFIG_NET_SENDTOSELF ifdefs from tcp*.c code
it might be more palatable.
4) I haven't reviewed the ramifications of the route lookup changes,
that is Alexey's territory.

Sorry, these changes are pretty ugly right now.