Badari Pulavarty wrote:
>
> ...
> > The other thing we've lost is the BIO-pruning and recycling effect: the
> > current direct-io code will reap BIOs while it is actually submitting
> > them, so the peak consumption is kept under control. Plus there are
> > cache-warmness issues. But without having a process there to do all this,
> > we obviously have to lose some things.
> >
>
> I don't follow you. In original code, we only reap the BIO's on which IO
> is complete. How is it controlling peak consumption ?
Ah. The current direct-io code will, while submitting those BIOs,
occasionally go and see if any have completed already. If they have
then they are processed and returned to the global BIO pool.
But you're returning them from within end_io, so no prob.