2013-03-29 14:59:43

by Nicolas Ferre

[permalink] [raw]
Subject: [GIT PULL] at91: DT changes for 3.10 #2

Arnd, Olof,

Here is a pull-request for AT91 that is dedicated to Device Tree
modifications. It is stacked on the material that you already have
for 3.10 in your arm-soc/at91/dt branch.
Following our discussion with Arnd, I added the non-urgent patches that I
already proposed too late for 3.9. I also included the moving of macb node
and kept the original patch.

Thanks, best regards,

The following changes since commit 6901d947be5ba1245a0f63271355b95f9056a362:

ARM: at91/at91sam9x5cm: add 1-wire chip on CM board (2013-03-21 16:07:15 +0100)

are available in the git repository at:

git://github.com/at91linux/linux-at91.git tags/at91-dt

for you to fetch changes up to cc2e191b0ccc5a987fdb29261ab9c264c608924d:

ARM: at91/dt: fix macb node declaration (2013-03-29 10:02:04 +0100)

----------------------------------------------------------------
One macb DT node move for 9x5 family: 9g15 doesn't
have an Ethernet interface.
Little fixes mainly related to at91sam9x5 DT and the
RTC addition.
Addition of the Acme Systems Aria G25 board.

----------------------------------------------------------------
Douglas Gilbert (1):
ARM: at91: add Acme Systems Aria G25 board

Nicolas Ferre (5):
ARM: at91/at91sam9x5: add RTC node
ARM: at91/trivial: typos in compatible property
ARM: at91/trivial: fix model name for SAM9G15-EK
ARM: at91: remove partial parameter in bootargs for at91sam9x5ek.dtsi
ARM: at91/dt: fix macb node declaration

arch/arm/boot/dts/ariag25.dts | 175 +++++++++++++++++++++++++++++++++++
arch/arm/boot/dts/at91sam9g15.dtsi | 2 +-
arch/arm/boot/dts/at91sam9g15ek.dts | 2 +-
arch/arm/boot/dts/at91sam9g25.dtsi | 2 +-
arch/arm/boot/dts/at91sam9g25ek.dts | 9 ++
arch/arm/boot/dts/at91sam9g35.dtsi | 2 +-
arch/arm/boot/dts/at91sam9g35ek.dts | 9 ++
arch/arm/boot/dts/at91sam9x25.dtsi | 2 +-
arch/arm/boot/dts/at91sam9x25ek.dts | 14 +++
arch/arm/boot/dts/at91sam9x35.dtsi | 2 +-
arch/arm/boot/dts/at91sam9x35ek.dts | 9 ++
arch/arm/boot/dts/at91sam9x5.dtsi | 7 ++
arch/arm/boot/dts/at91sam9x5ek.dtsi | 7 +-
13 files changed, 230 insertions(+), 12 deletions(-)
create mode 100644 arch/arm/boot/dts/ariag25.dts

--
Nicolas Ferre


2013-04-02 18:49:54

by Olof Johansson

[permalink] [raw]
Subject: Re: [GIT PULL] at91: DT changes for 3.10 #2

On Fri, Mar 29, 2013 at 03:59:39PM +0100, Nicolas Ferre wrote:
> Arnd, Olof,
>
> Here is a pull-request for AT91 that is dedicated to Device Tree
> modifications. It is stacked on the material that you already have
> for 3.10 in your arm-soc/at91/dt branch.
> Following our discussion with Arnd, I added the non-urgent patches that I
> already proposed too late for 3.9. I also included the moving of macb node
> and kept the original patch.
>
> Thanks, best regards,
>
> The following changes since commit 6901d947be5ba1245a0f63271355b95f9056a362:
>
> ARM: at91/at91sam9x5cm: add 1-wire chip on CM board (2013-03-21 16:07:15 +0100)
>
> are available in the git repository at:
>
> git://github.com/at91linux/linux-at91.git tags/at91-dt
>
> for you to fetch changes up to cc2e191b0ccc5a987fdb29261ab9c264c608924d:
>
> ARM: at91/dt: fix macb node declaration (2013-03-29 10:02:04 +0100)
>
> ----------------------------------------------------------------
> One macb DT node move for 9x5 family: 9g15 doesn't
> have an Ethernet interface.
> Little fixes mainly related to at91sam9x5 DT and the
> RTC addition.
> Addition of the Acme Systems Aria G25 board.
>
> ----------------------------------------------------------------
> Douglas Gilbert (1):
> ARM: at91: add Acme Systems Aria G25 board

Hi,

I just replied to the above patch -- please prefix the dts files with the
platform so it's easier to navigate the directory.

Otherwise the branch contents looks good, so send a fresh request when you've
respun.

Also, the new dts isn't added to the Makefile, please add it.


-Olof

2013-04-03 07:45:52

by Nicolas Ferre

[permalink] [raw]
Subject: Re: [GIT PULL] at91: DT changes for 3.10 #2

On 04/02/2013 08:49 PM, Olof Johansson :
> On Fri, Mar 29, 2013 at 03:59:39PM +0100, Nicolas Ferre wrote:
>> Arnd, Olof,
>>
>> Here is a pull-request for AT91 that is dedicated to Device Tree
>> modifications. It is stacked on the material that you already have
>> for 3.10 in your arm-soc/at91/dt branch.
>> Following our discussion with Arnd, I added the non-urgent patches that I
>> already proposed too late for 3.9. I also included the moving of macb node
>> and kept the original patch.
>>
>> Thanks, best regards,
>>
>> The following changes since commit 6901d947be5ba1245a0f63271355b95f9056a362:
>>
>> ARM: at91/at91sam9x5cm: add 1-wire chip on CM board (2013-03-21 16:07:15 +0100)
>>
>> are available in the git repository at:
>>
>> git://github.com/at91linux/linux-at91.git tags/at91-dt
>>
>> for you to fetch changes up to cc2e191b0ccc5a987fdb29261ab9c264c608924d:
>>
>> ARM: at91/dt: fix macb node declaration (2013-03-29 10:02:04 +0100)
>>
>> ----------------------------------------------------------------
>> One macb DT node move for 9x5 family: 9g15 doesn't
>> have an Ethernet interface.
>> Little fixes mainly related to at91sam9x5 DT and the
>> RTC addition.
>> Addition of the Acme Systems Aria G25 board.
>>
>> ----------------------------------------------------------------
>> Douglas Gilbert (1):
>> ARM: at91: add Acme Systems Aria G25 board
>
> Hi,
>
> I just replied to the above patch -- please prefix the dts files with the
> platform so it's easier to navigate the directory.

Yes, I have to make sure that everybody agree on our side...

> Otherwise the branch contents looks good, so send a fresh request when you've
> respun.
>
> Also, the new dts isn't added to the Makefile, please add it.

Ok, I will do. Maybe I can also stack a DT related patch about ADC
support that I was planning to add in another pull-request covering the
same topic.

Thanks, best regards,
--
Nicolas Ferre

2013-04-04 09:37:32

by Nicolas Ferre

[permalink] [raw]
Subject: Re: [GIT PULL] at91: DT changes for 3.10 #2

On 04/03/2013 09:45 AM, Nicolas Ferre :
> On 04/02/2013 08:49 PM, Olof Johansson :
>> On Fri, Mar 29, 2013 at 03:59:39PM +0100, Nicolas Ferre wrote:
>>> Arnd, Olof,
>>>
>>> Here is a pull-request for AT91 that is dedicated to Device Tree
>>> modifications. It is stacked on the material that you already have
>>> for 3.10 in your arm-soc/at91/dt branch.
>>> Following our discussion with Arnd, I added the non-urgent patches that I
>>> already proposed too late for 3.9. I also included the moving of macb node
>>> and kept the original patch.
>>>
>>> Thanks, best regards,
>>>
>>> The following changes since commit 6901d947be5ba1245a0f63271355b95f9056a362:
>>>
>>> ARM: at91/at91sam9x5cm: add 1-wire chip on CM board (2013-03-21 16:07:15 +0100)
>>>
>>> are available in the git repository at:
>>>
>>> git://github.com/at91linux/linux-at91.git tags/at91-dt
>>>
>>> for you to fetch changes up to cc2e191b0ccc5a987fdb29261ab9c264c608924d:
>>>
>>> ARM: at91/dt: fix macb node declaration (2013-03-29 10:02:04 +0100)
>>>
>>> ----------------------------------------------------------------
>>> One macb DT node move for 9x5 family: 9g15 doesn't
>>> have an Ethernet interface.
>>> Little fixes mainly related to at91sam9x5 DT and the
>>> RTC addition.
>>> Addition of the Acme Systems Aria G25 board.
>>>
>>> ----------------------------------------------------------------
>>> Douglas Gilbert (1):
>>> ARM: at91: add Acme Systems Aria G25 board
>>
>> Hi,
>>
>> I just replied to the above patch -- please prefix the dts files with the
>> platform so it's easier to navigate the directory.

I do not want to spark a debate here, but moving to directories per
"mach" earlier would have made things easier. If I recall well,
Jean-Christophe has proposed it a long time ago...

> Yes, I have to make sure that everybody agree on our side...

The difficult point with this prefix... well it is difficult to tell...
our product will never be called "at91" again!
So, yes, our Linux identity is still "at91" and we are pretty attached
to it but our newer products are named "sam" + "core" + "product family"
which results in our newer family: "sama5d3" (note the at91 is missing)...

=> anyway, we think that the at91 prefix is still vivid in Linux
community and we consider it as a good choice for now.
So, I may rename the newly introduced "sama5d3*.dts[i]" files with
"at91-sama5d3*.dts[i]" (while .c/.h files will remain the same).

>> Otherwise the branch contents looks good, so send a fresh request when you've
>> respun.
>>
>> Also, the new dts isn't added to the Makefile, please add it.
>
> Ok, I will do. Maybe I can also stack a DT related patch about ADC
> support that I was planning to add in another pull-request covering the
> same topic.
>
> Thanks, best regards,
>


--
Nicolas Ferre

2013-04-04 15:42:37

by Nicolas Ferre

[permalink] [raw]
Subject: [PATCH v3] ARM: at91: add Acme Systems Aria G25 board

From: Douglas Gilbert <[email protected]>

Signed-off-by: Douglas Gilbert <[email protected]>
Signed-off-by: Nicolas Ferre <[email protected]>
---
Hi all,

Here is the third revision of this patch. I plan to include it in a
pull-request real-soon-now!

v3: - move to "at91-" prefix for .dts[i] files
- remove the rtc activation code because of the ongoing discussions
about this IP and its DT binding.

arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/at91-ariag25.dts | 171 +++++++++++++++++++++++++++++++++++++
2 files changed, 172 insertions(+)
create mode 100644 arch/arm/boot/dts/at91-ariag25.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 4c7f8a8..b07f162 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -27,6 +27,7 @@ dtb-$(CONFIG_ARCH_AT91) += pm9g45.dtb
# sam9n12
dtb-$(CONFIG_ARCH_AT91) += at91sam9n12ek.dtb
# sam9x5
+dtb-$(CONFIG_ARCH_AT91) += at91-ariag25.dtb
dtb-$(CONFIG_ARCH_AT91) += at91sam9g15ek.dtb
dtb-$(CONFIG_ARCH_AT91) += at91sam9g25ek.dtb
dtb-$(CONFIG_ARCH_AT91) += at91sam9g35ek.dtb
diff --git a/arch/arm/boot/dts/at91-ariag25.dts b/arch/arm/boot/dts/at91-ariag25.dts
new file mode 100644
index 0000000..c7aebba
--- /dev/null
+++ b/arch/arm/boot/dts/at91-ariag25.dts
@@ -0,0 +1,171 @@
+/*
+ * at91-ariag25.dts - Device Tree file for Acme Systems Aria G25 (AT91SAM9G25 based)
+ *
+ * Copyright (C) 2013 Douglas Gilbert <[email protected]>,
+ * Robert Nelson <[email protected]>
+ *
+ * Licensed under GPLv2 or later.
+ */
+/dts-v1/;
+/include/ "at91sam9g25.dtsi"
+
+/ {
+ model = "Acme Systems Aria G25";
+ compatible = "acme,ariag25", "atmel,at91sam9x5ek",
+ "atmel,at91sam9x5", "atmel,at91sam9";
+
+ aliases {
+ serial0 = &dbgu;
+ serial1 = &usart0;
+ serial2 = &usart1;
+ serial3 = &usart2;
+ serial4 = &usart3;
+ serial5 = &uart0;
+ };
+
+ chosen {
+ bootargs = "console=ttyS0,115200 root=/dev/mmcblk0p2 rw rootwait";
+ };
+
+ memory {
+ /* 128 MB, change this for 256 MB revision */
+ reg = <0x20000000 0x8000000>;
+ };
+
+ clocks {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ main_clock: [email protected] {
+ compatible = "atmel,osc", "fixed-clock";
+ clock-frequency = <12000000>;
+ };
+ };
+
+ ahb {
+ apb {
+ mmc0: [email protected] {
+ /* N.B. Aria has no SD card detect (CD), assumed present */
+
+ pinctrl-0 = <
+ &pinctrl_mmc0_slot0_clk_cmd_dat0
+ &pinctrl_mmc0_slot0_dat1_3>;
+ status = "okay";
+ [email protected] {
+ reg = <0>;
+ bus-width = <4>;
+ };
+ };
+
+ i2c0: [email protected] {
+ status = "okay";
+ };
+
+ i2c1: [email protected] {
+ status = "okay";
+ };
+
+ /* TWD2+TCLK2 hidden behind ethernet, so no i2c2 */
+
+ usart0: [email protected] {
+ pinctrl-0 = <&pinctrl_usart0
+ &pinctrl_usart0_rts
+ &pinctrl_usart0_cts>;
+ status = "okay";
+ };
+
+ usart1: [email protected] {
+ pinctrl-0 = <&pinctrl_usart1
+ /* &pinctrl_usart1_rts */
+ /* &pinctrl_usart1_cts */
+ >;
+ status = "okay";
+ };
+
+ usart2: [email protected] {
+ /* cannot activate RTS2+CTS2, clash with
+ * ethernet on PB0 and PB1 */
+ pinctrl-0 = <&pinctrl_usart2>;
+ status = "okay";
+ };
+
+ usart3: [email protected] {
+ compatible = "atmel,at91sam9260-usart";
+ reg = <0xf8028000 0x200>;
+ interrupts = <8 4 5>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usart3
+ /* &pinctrl_usart3_rts */
+ /* &pinctrl_usart3_cts */
+ >;
+ status = "okay";
+ };
+
+ macb0: [email protected] {
+ phy-mode = "rmii";
+ /*
+ * following can be overwritten by bootloader:
+ * for example u-boot 'ftd set' command
+ */
+ local-mac-address = [00 00 00 00 00 00];
+ status = "okay";
+ };
+
+ uart0: [email protected] {
+ compatible = "atmel,at91sam9260-usart";
+ reg = <0xf8040000 0x200>;
+ interrupts = <15 4 5>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_uart0>;
+ status = "okay";
+ };
+
+ adc0: [email protected] {
+ status = "okay";
+ atmel,adc-channels-used = <0xf>;
+ atmel,adc-num-channels = <4>;
+ };
+
+ dbgu: [email protected] {
+ status = "okay";
+ };
+
+ [email protected] {
+ w1_0 {
+ pinctrl_w1_0: w1_0-0 {
+ atmel,pins = <0 21 0x0 0x1>; /* PA21 PIO, pull-up */
+ };
+ };
+ };
+ };
+
+ usb0: [email protected] {
+ status = "okay";
+ num-ports = <3>;
+ };
+
+ usb1: [email protected] {
+ status = "okay";
+ };
+ };
+
+ leds {
+ compatible = "gpio-leds";
+
+ /* little green LED in middle of Aria G25 module */
+ aria_led {
+ label = "aria_led";
+ gpios = <&pioB 8 0>; /* PB8 */
+ linux,default-trigger = "heartbeat";
+ };
+
+ };
+
+ [email protected] {
+ compatible = "w1-gpio";
+ gpios = <&pioA 21 1>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_w1_0>;
+ };
+};
--
1.8.0

2013-04-04 17:00:04

by Nicolas Ferre

[permalink] [raw]
Subject: [GIT PULL] at91: DT changes for 3.10 #3

Arnd, Olof,

Here is the refreshed pull-request for AT91 that is dedicated to Device Tree
modifications. It is stacked on the material that you already have
for 3.10 in your arm-soc/at91/dt branch.
Following our discussion with Arnd, I added the non-urgent patches that I
already proposed too late for 3.9. I also included the moving of macb node
and kept the original patch.

As Olof asked, I renamed the Aria board dts file: at91-ariag25.dts and placed
it in the Makefile. I also took the advantage of this delay to stack two more
DT related patches.

Thanks, best regards,

The following changes since commit 6901d947be5ba1245a0f63271355b95f9056a362:

ARM: at91/at91sam9x5cm: add 1-wire chip on CM board (2013-03-21 16:07:15 +0100)

are available in the git repository at:

git://github.com/at91linux/linux-at91.git tags/at91-dt

for you to fetch changes up to f10491fff07dcced77f8ab1b3bc1f8e18715bfb9:

ARM: at91/at91sam9260.dtsi: fix u(s)art pinctrl encoding (2013-04-04 18:31:17 +0200)

----------------------------------------------------------------
One macb DT node move for 9x5 family: 9g15 doesn't
have an Ethernet interface.
Little fixes mainly related to at91sam9x5 DT, IIO ADC bindings,
pinctrl for at91sam9260/g20 DT and the RTC addition.
Addition of the Acme Systems Aria G25 board.

----------------------------------------------------------------
Douglas Gilbert (2):
ARM: at91: add Acme Systems Aria G25 board
ARM: at91/at91sam9260.dtsi: fix u(s)art pinctrl encoding

Ludovic Desroches (1):
ARM: at91: dts: add adc resolution stuff

Nicolas Ferre (5):
ARM: at91/at91sam9x5: add RTC node
ARM: at91/trivial: typos in compatible property
ARM: at91/trivial: fix model name for SAM9G15-EK
ARM: at91: remove partial parameter in bootargs for at91sam9x5ek.dtsi
ARM: at91/dt: fix macb node declaration

arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/at91-ariag25.dts | 171 +++++++++++++++++++++++++++++++++++
arch/arm/boot/dts/at91sam9260.dtsi | 19 ++--
arch/arm/boot/dts/at91sam9g15.dtsi | 2 +-
arch/arm/boot/dts/at91sam9g15ek.dts | 2 +-
arch/arm/boot/dts/at91sam9g25.dtsi | 2 +-
arch/arm/boot/dts/at91sam9g25ek.dts | 9 ++
arch/arm/boot/dts/at91sam9g35.dtsi | 2 +-
arch/arm/boot/dts/at91sam9g35ek.dts | 9 ++
arch/arm/boot/dts/at91sam9g45.dtsi | 3 +
arch/arm/boot/dts/at91sam9x25.dtsi | 2 +-
arch/arm/boot/dts/at91sam9x25ek.dts | 14 +++
arch/arm/boot/dts/at91sam9x35.dtsi | 2 +-
arch/arm/boot/dts/at91sam9x35ek.dts | 9 ++
arch/arm/boot/dts/at91sam9x5.dtsi | 10 ++
arch/arm/boot/dts/at91sam9x5ek.dtsi | 7 +-
16 files changed, 244 insertions(+), 20 deletions(-)
create mode 100644 arch/arm/boot/dts/at91-ariag25.dts

--
Nicolas Ferre

2013-04-04 17:04:09

by Douglas Gilbert

[permalink] [raw]
Subject: Re: [PATCH v3] ARM: at91: add Acme Systems Aria G25 board

On 13-04-04 11:42 AM, Nicolas Ferre wrote:
> From: Douglas Gilbert <[email protected]>
>
> Signed-off-by: Douglas Gilbert <[email protected]>
> Signed-off-by: Nicolas Ferre <[email protected]>
> ---
> Hi all,
>
> Here is the third revision of this patch. I plan to include it in a
> pull-request real-soon-now!
>
> v3: - move to "at91-" prefix for .dts[i] files
> - remove the rtc activation code because of the ongoing discussions
> about this IP and its DT binding.
>

Nicolas,
It's a pity that the rtc activation code is removed.
At worst:
[email protected] {
status = "okay";
};

does nothing. Also it is unlikely to be changed by any
movement on the rtc-at91rm9200 front.


The lack of use of uart1 is for my own, private reasons.
I think it would be more generally useful to show uart1's
definition and disable it as shown in the attached patch
fragment.


I also note that my date line was removed. I like dates,
so when I add comments like "the i2c-at91 driver is broken
for the SAM9G20 ** and use the i2c-gpio driver instead" then
this is not taken as an eternal truth. It worked in the
past and hopefully it will work again in the future.

While on the subject of I2C, I'm getting tired of seeing
this oft-copied line:
i2c-gpio,delay-us = <2>; /* ~100 kHz */

It is the clock half period in microseconds and for the 100 kHz
(standard) I2C clock speed, it should be 5. Due to rounding
(up) that gives a measured clock speed of around 88 kHz on
my equipment. Crappy I2C devices *** seem to cope better
with 12% below the standard clock frequency than 80% above
it.

Doug Gilbert

** broken in my tests on the FoxG20 with lk 3.9.0-rc5

*** if my experience is anything to go by there are many
dodgy I2C devices, probably using I2C bit banging
code borrowed from Wikipedia.



Attachments:
ariag25_390rc5_dg1.patch (1.01 kB)

2013-04-04 17:19:56

by Olof Johansson

[permalink] [raw]
Subject: Re: [GIT PULL] at91: DT changes for 3.10 #2

On Thu, Apr 4, 2013 at 2:37 AM, Nicolas Ferre <[email protected]> wrote:
> On 04/03/2013 09:45 AM, Nicolas Ferre :
>> On 04/02/2013 08:49 PM, Olof Johansson :
>>> On Fri, Mar 29, 2013 at 03:59:39PM +0100, Nicolas Ferre wrote:
>>>> Arnd, Olof,
>>>>
>>>> Here is a pull-request for AT91 that is dedicated to Device Tree
>>>> modifications. It is stacked on the material that you already have
>>>> for 3.10 in your arm-soc/at91/dt branch.
>>>> Following our discussion with Arnd, I added the non-urgent patches that I
>>>> already proposed too late for 3.9. I also included the moving of macb node
>>>> and kept the original patch.
>>>>
>>>> Thanks, best regards,
>>>>
>>>> The following changes since commit 6901d947be5ba1245a0f63271355b95f9056a362:
>>>>
>>>> ARM: at91/at91sam9x5cm: add 1-wire chip on CM board (2013-03-21 16:07:15 +0100)
>>>>
>>>> are available in the git repository at:
>>>>
>>>> git://github.com/at91linux/linux-at91.git tags/at91-dt
>>>>
>>>> for you to fetch changes up to cc2e191b0ccc5a987fdb29261ab9c264c608924d:
>>>>
>>>> ARM: at91/dt: fix macb node declaration (2013-03-29 10:02:04 +0100)
>>>>
>>>> ----------------------------------------------------------------
>>>> One macb DT node move for 9x5 family: 9g15 doesn't
>>>> have an Ethernet interface.
>>>> Little fixes mainly related to at91sam9x5 DT and the
>>>> RTC addition.
>>>> Addition of the Acme Systems Aria G25 board.
>>>>
>>>> ----------------------------------------------------------------
>>>> Douglas Gilbert (1):
>>>> ARM: at91: add Acme Systems Aria G25 board
>>>
>>> Hi,
>>>
>>> I just replied to the above patch -- please prefix the dts files with the
>>> platform so it's easier to navigate the directory.
>
> I do not want to spark a debate here, but moving to directories per
> "mach" earlier would have made things easier. If I recall well,
> Jean-Christophe has proposed it a long time ago...

Yeah, we're at a size where it's starting to be warranted (powerpc
does so already). It does cut down on the cross-exposure and review
though and puts everyone in their own little sandbox, so there's some
benefit in keeping it flat.

I think that benefit is losing its appeal though. But let's hold off
for another couple of releases with the churn of moving things out in
subdirectories.

>> Yes, I have to make sure that everybody agree on our side...
>
> The difficult point with this prefix... well it is difficult to tell...
> our product will never be called "at91" again!

That's a marketing issue, not a technical kernel one. If we create
subdirectory it makes sense to name it 'atmel' instead of 'at91'
though, I'm sure.

> So, yes, our Linux identity is still "at91" and we are pretty attached
> to it but our newer products are named "sam" + "core" + "product family"
> which results in our newer family: "sama5d3" (note the at91 is missing)...
> => anyway, we think that the at91 prefix is still vivid in Linux
> community and we consider it as a good choice for now.
> So, I may rename the newly introduced "sama5d3*.dts[i]" files with
> "at91-sama5d3*.dts[i]" (while .c/.h files will remain the same).

Sounds reasonable, or stick to the same format as you already have
with at91sam9 families. When we move to subdirectories it might make
sense to stick them under 'atmel' instead of 'at91' though and drop
the prefix.



-Olof

Subject: Re: [GIT PULL] at91: DT changes for 3.10 #2

On 10:19 Thu 04 Apr , Olof Johansson wrote:
> On Thu, Apr 4, 2013 at 2:37 AM, Nicolas Ferre <[email protected]> wrote:
> > On 04/03/2013 09:45 AM, Nicolas Ferre :
> >> On 04/02/2013 08:49 PM, Olof Johansson :
> >>> On Fri, Mar 29, 2013 at 03:59:39PM +0100, Nicolas Ferre wrote:
> >>>> Arnd, Olof,
> >>>>
> >>>> Here is a pull-request for AT91 that is dedicated to Device Tree
> >>>> modifications. It is stacked on the material that you already have
> >>>> for 3.10 in your arm-soc/at91/dt branch.
> >>>> Following our discussion with Arnd, I added the non-urgent patches that I
> >>>> already proposed too late for 3.9. I also included the moving of macb node
> >>>> and kept the original patch.
> >>>>
> >>>> Thanks, best regards,
> >>>>
> >>>> The following changes since commit 6901d947be5ba1245a0f63271355b95f9056a362:
> >>>>
> >>>> ARM: at91/at91sam9x5cm: add 1-wire chip on CM board (2013-03-21 16:07:15 +0100)
> >>>>
> >>>> are available in the git repository at:
> >>>>
> >>>> git://github.com/at91linux/linux-at91.git tags/at91-dt
> >>>>
> >>>> for you to fetch changes up to cc2e191b0ccc5a987fdb29261ab9c264c608924d:
> >>>>
> >>>> ARM: at91/dt: fix macb node declaration (2013-03-29 10:02:04 +0100)
> >>>>
> >>>> ----------------------------------------------------------------
> >>>> One macb DT node move for 9x5 family: 9g15 doesn't
> >>>> have an Ethernet interface.
> >>>> Little fixes mainly related to at91sam9x5 DT and the
> >>>> RTC addition.
> >>>> Addition of the Acme Systems Aria G25 board.
> >>>>
> >>>> ----------------------------------------------------------------
> >>>> Douglas Gilbert (1):
> >>>> ARM: at91: add Acme Systems Aria G25 board
> >>>
> >>> Hi,
> >>>
> >>> I just replied to the above patch -- please prefix the dts files with the
> >>> platform so it's easier to navigate the directory.
> >
> > I do not want to spark a debate here, but moving to directories per
> > "mach" earlier would have made things easier. If I recall well,
> > Jean-Christophe has proposed it a long time ago...
>
> Yeah, we're at a size where it's starting to be warranted (powerpc
> does so already). It does cut down on the cross-exposure and review
> though and puts everyone in their own little sandbox, so there's some
> benefit in keeping it flat.
>
> I think that benefit is losing its appeal though. But let's hold off
> for another couple of releases with the churn of moving things out in
> subdirectories.
>
> >> Yes, I have to make sure that everybody agree on our side...
> >
> > The difficult point with this prefix... well it is difficult to tell...
> > our product will never be called "at91" again!
>
> That's a marketing issue, not a technical kernel one. If we create
> subdirectory it makes sense to name it 'atmel' instead of 'at91'
> though, I'm sure.
>
> > So, yes, our Linux identity is still "at91" and we are pretty attached
> > to it but our newer products are named "sam" + "core" + "product family"
> > which results in our newer family: "sama5d3" (note the at91 is missing)...
> > => anyway, we think that the at91 prefix is still vivid in Linux
> > community and we consider it as a good choice for now.
> > So, I may rename the newly introduced "sama5d3*.dts[i]" files with
> > "at91-sama5d3*.dts[i]" (while .c/.h files will remain the same).
>
> Sounds reasonable, or stick to the same format as you already have
> with at91sam9 families. When we move to subdirectories it might make
> sense to stick them under 'atmel' instead of 'at91' though and drop
> the prefix.
I've a rfc for this as I do no lihe idea of prefix

and it make the grep search mo complex

I send a patch to clean the '\\' stuff in this Makefile

can you take

I send the dir split on the top of this
>
>
>
> -Olof

2013-04-09 08:18:08

by Nicolas Ferre

[permalink] [raw]
Subject: Re: [GIT PULL] at91: DT changes for 3.10 #3

On 04/04/2013 06:59 PM, Nicolas Ferre :
> Arnd, Olof,
>
> Here is the refreshed pull-request for AT91 that is dedicated to Device Tree
> modifications. It is stacked on the material that you already have
> for 3.10 in your arm-soc/at91/dt branch.
> Following our discussion with Arnd, I added the non-urgent patches that I
> already proposed too late for 3.9. I also included the moving of macb node
> and kept the original patch.
>
> As Olof asked, I renamed the Aria board dts file: at91-ariag25.dts and placed
> it in the Makefile. I also took the advantage of this delay to stack two more
> DT related patches.

Ping?

I saw that you made an update to arm-soc yesterday, and maybe you have
forgotten this pull-request?

Thanks, bye,


> Thanks, best regards,
>
> The following changes since commit 6901d947be5ba1245a0f63271355b95f9056a362:
>
> ARM: at91/at91sam9x5cm: add 1-wire chip on CM board (2013-03-21 16:07:15 +0100)
>
> are available in the git repository at:
>
> git://github.com/at91linux/linux-at91.git tags/at91-dt
>
> for you to fetch changes up to f10491fff07dcced77f8ab1b3bc1f8e18715bfb9:
>
> ARM: at91/at91sam9260.dtsi: fix u(s)art pinctrl encoding (2013-04-04 18:31:17 +0200)
>
> ----------------------------------------------------------------
> One macb DT node move for 9x5 family: 9g15 doesn't
> have an Ethernet interface.
> Little fixes mainly related to at91sam9x5 DT, IIO ADC bindings,
> pinctrl for at91sam9260/g20 DT and the RTC addition.
> Addition of the Acme Systems Aria G25 board.
>
> ----------------------------------------------------------------
> Douglas Gilbert (2):
> ARM: at91: add Acme Systems Aria G25 board
> ARM: at91/at91sam9260.dtsi: fix u(s)art pinctrl encoding
>
> Ludovic Desroches (1):
> ARM: at91: dts: add adc resolution stuff
>
> Nicolas Ferre (5):
> ARM: at91/at91sam9x5: add RTC node
> ARM: at91/trivial: typos in compatible property
> ARM: at91/trivial: fix model name for SAM9G15-EK
> ARM: at91: remove partial parameter in bootargs for at91sam9x5ek.dtsi
> ARM: at91/dt: fix macb node declaration
>
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/at91-ariag25.dts | 171 +++++++++++++++++++++++++++++++++++
> arch/arm/boot/dts/at91sam9260.dtsi | 19 ++--
> arch/arm/boot/dts/at91sam9g15.dtsi | 2 +-
> arch/arm/boot/dts/at91sam9g15ek.dts | 2 +-
> arch/arm/boot/dts/at91sam9g25.dtsi | 2 +-
> arch/arm/boot/dts/at91sam9g25ek.dts | 9 ++
> arch/arm/boot/dts/at91sam9g35.dtsi | 2 +-
> arch/arm/boot/dts/at91sam9g35ek.dts | 9 ++
> arch/arm/boot/dts/at91sam9g45.dtsi | 3 +
> arch/arm/boot/dts/at91sam9x25.dtsi | 2 +-
> arch/arm/boot/dts/at91sam9x25ek.dts | 14 +++
> arch/arm/boot/dts/at91sam9x35.dtsi | 2 +-
> arch/arm/boot/dts/at91sam9x35ek.dts | 9 ++
> arch/arm/boot/dts/at91sam9x5.dtsi | 10 ++
> arch/arm/boot/dts/at91sam9x5ek.dtsi | 7 +-
> 16 files changed, 244 insertions(+), 20 deletions(-)
> create mode 100644 arch/arm/boot/dts/at91-ariag25.dts
>


--
Nicolas Ferre

2013-04-09 09:49:57

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [GIT PULL] at91: DT changes for 3.10 #3

On Tuesday 09 April 2013, Nicolas Ferre wrote:
> Ping?
>
> I saw that you made an update to arm-soc yesterday, and maybe you have
> forgotten this pull-request?
>

I got about halfway through, but it's still in the queue, planning to merge
it today. My default sort order in the email client is "thread with latest
reply first", so when I went through my pull request folder from the bottom,
I ended up addressing newer mails first ;-)

Thanks for the reminder.

Arnd

2013-04-09 10:49:51

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [GIT PULL] at91: DT changes for 3.10 #3

On Thursday 04 April 2013, Nicolas Ferre wrote:
> Here is the refreshed pull-request for AT91 that is dedicated to Device Tree
> modifications. It is stacked on the material that you already have
> for 3.10 in your arm-soc/at91/dt branch.
> Following our discussion with Arnd, I added the non-urgent patches that I
> already proposed too late for 3.9. I also included the moving of macb node
> and kept the original patch.
>
> As Olof asked, I renamed the Aria board dts file: at91-ariag25.dts and placed
> it in the Makefile. I also took the advantage of this delay to stack two more
> DT related patches.
>

Pulled into next/dt, thanks!

Arnd

2013-04-18 09:01:45

by Nicolas Ferre

[permalink] [raw]
Subject: Re: [PATCH v3] ARM: at91: add Acme Systems Aria G25 board

On 04/04/2013 07:03 PM, Douglas Gilbert :
> On 13-04-04 11:42 AM, Nicolas Ferre wrote:
>> From: Douglas Gilbert <[email protected]>
>>
>> Signed-off-by: Douglas Gilbert <[email protected]>
>> Signed-off-by: Nicolas Ferre <[email protected]>
>> ---
>> Hi all,
>>
>> Here is the third revision of this patch. I plan to include it in a
>> pull-request real-soon-now!
>>
>> v3: - move to "at91-" prefix for .dts[i] files
>> - remove the rtc activation code because of the ongoing discussions
>> about this IP and its DT binding.
>>
>
> Nicolas,
> It's a pity that the rtc activation code is removed.
> At worst:
> [email protected] {
> status = "okay";
> };

I try to re-enalbe it when the at91sam9x5.dtsi exposes a compatibility
sting != at91rm9200-rtc

will soon appear on mailing-list.

> does nothing. Also it is unlikely to be changed by any
> movement on the rtc-at91rm9200 front.
>
>
> The lack of use of uart1 is for my own, private reasons.
> I think it would be more generally useful to show uart1's
> definition and disable it as shown in the attached patch
> fragment.

Well, if uart1 is available on Aria board, I should enable it! If you do
not want it on your own design, you must modify the .dts yourself. So I
plan to have an "okay" status on it (and move the definition itself to
the generic .dtsi).


> I also note that my date line was removed. I like dates,
> so when I add comments like "the i2c-at91 driver is broken
> for the SAM9G20 ** and use the i2c-gpio driver instead" then
> this is not taken as an eternal truth.

Yep, I see, but I try to cleanup the patch as much as I can. If you want
it untouched, provide me a standard formated patch.

> It worked in the
> past and hopefully it will work again in the future.
>
> While on the subject of I2C, I'm getting tired of seeing
> this oft-copied line:
> i2c-gpio,delay-us = <2>; /* ~100 kHz */
>
> It is the clock half period in microseconds and for the 100 kHz
> (standard) I2C clock speed, it should be 5. Due to rounding
> (up) that gives a measured clock speed of around 88 kHz on
> my equipment. Crappy I2C devices *** seem to cope better
> with 12% below the standard clock frequency than 80% above
> it.

Makes sense: I keep it in mind. In parallel, it can be interesting if
you can send me a patch with all these mistakes corrected ;-)

Bye,
--
Nicolas Ferre

2013-04-18 10:17:15

by Nicolas Ferre

[permalink] [raw]
Subject: Re: [PATCH v3] ARM: at91: add Acme Systems Aria G25 board

On 04/18/2013 11:01 AM, Nicolas Ferre :
> On 04/04/2013 07:03 PM, Douglas Gilbert :

[..]

>> The lack of use of uart1 is for my own, private reasons.
>> I think it would be more generally useful to show uart1's
>> definition and disable it as shown in the attached patch
>> fragment.
>
> Well, if uart1 is available on Aria board, I should enable it! If you do
> not want it on your own design, you must modify the .dts yourself. So I
> plan to have an "okay" status on it (and move the definition itself to
> the generic .dtsi).

Update: I have just checked the ACME website and both UART0 and UART1
pins are expected to be used as GPIOs. So maybe we should mark them as
"disabled":

+ /*
+ * UART1 pins are marked as GPIO on Aria
+ * documentation: change to "okay" if you need
+ * an additional serial port
+ */
+ uart0: [email protected] {
+ status = "disabled";
+ };
+
+ uart1: [email protected] {
+ status = "disabled";
+ };

(uart0 definition moved to at91sam9x5.dtsi)
What do you think?

[..]

Bye,
--
Nicolas Ferre