2002-09-21 11:17:42

by adam

[permalink] [raw]
Subject: [PATCH] __KERNEL__ pasting in drivers/net/wan/cycx_x25.c

This patch cleans up the __FUNCTION__ pasting to the new
standard.

Adam


--- drivers/net/wan/cycx_x25.c.orig Sat Sep 21 21:07:25 2002
+++ drivers/net/wan/cycx_x25.c Sat Sep 21 21:08:28 2002
@@ -1446,7 +1446,7 @@
unsigned char *ptr;

if ((skb = dev_alloc_skb(1)) == NULL) {
- printk(KERN_ERR __FUNCTION__ ": out of memory\n");
+ printk(KERN_ERR "%s: out of memory\n", __FUNCTION__);
return;
}


2002-09-21 12:24:20

by Bernd Eckenfels

[permalink] [raw]
Subject: Re: [PATCH] __KERNEL__ pasting in drivers/net/wan/cycx_x25.c

In article <[email protected]> you wrote:
> This patch cleans up the __FUNCTION__ pasting to the new
> standard.

is this normal, that we dont have a rate limit in those functions? And even
worse, that there is no error handling like signalling this back to the
channel? In this case this looks especially annoying, since it is a state
changing event, if when lost may totally screw up the state engine (if i
understand the comment "Send event (connection, disconnection, etc) to X.25
socket layer" right.

Greetings
Bernd