2002-09-21 19:48:59

by Adrian Bunk

[permalink] [raw]
Subject: [2.5 patch] fix drivers/char/generic_serial.c __FUNCTION__ breakage

Hi Roger,

I got the following compile error in 2.5.37:

<-- snip -->

gcc -Wp,-MD,./.generic_serial.o.d -D__KERNEL__
-I/home/bunk/linux/kernel-2.5/linux-2.5.37-full/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2
-fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe
-mpreferred-stack-boundary=2 -march=k6
-nostdinc -iwithprefix include -DKBUILD_BASENAME=generic_serial -c -o
generic_serial.o generic_serial.c
generic_serial.c: In function `gs_put_char':
generic_serial.c:67: called object is not a function
generic_serial.c:67: parse error before string constant
make[2]: *** [generic_serial.o] Error 1
make[2]: Leaving directory `/home/bunk/linux/kernel-2.5/linux-2.5.37-full/drivers/char'

<-- snip -->

The following patch fixes it:

--- linux-2.5.37-full/drivers/char/generic_serial.c.old 2002-09-21 21:33:46.000000000 +0200
+++ linux-2.5.37-full/drivers/char/generic_serial.c 2002-09-21 21:34:43.000000000 +0200
@@ -41,8 +41,8 @@
#define gs_dprintk(f, str...) /* nothing */

-#define func_enter() gs_dprintk (GS_DEBUG_FLOW, "gs: enter " __FUNCTION__ "\n")
-#define func_exit() gs_dprintk (GS_DEBUG_FLOW, "gs: exit " __FUNCTION__ "\n")
+#define func_enter() gs_dprintk (GS_DEBUG_FLOW, "gs: enter %s\n", __FUNCTION__)
+#define func_exit() gs_dprintk (GS_DEBUG_FLOW, "gs: exit %s\n", __FUNCTION__)

#define DECL /* Nothing */



You only think this is a free country. Like the US the UK spends a lot of
time explaining its a free country because its a police state.
Alan Cox