2002-09-22 22:37:00

by Jeff Garzik

[permalink] [raw]
Subject: Re: [kbuild-devel] linux kernel conf 0.6

One cosmetic thing I mentioned to Roman, Config.new needs to be changed
to something better, like conf.in or build.conf or somesuch.


2002-09-22 22:46:09

by Kai Germaschewski

[permalink] [raw]
Subject: Re: [kbuild-devel] linux kernel conf 0.6

On Sun, 22 Sep 2002, Jeff Garzik wrote:

> One cosmetic thing I mentioned to Roman, Config.new needs to be changed
> to something better, like conf.in or build.conf or somesuch.

I agree. (But I'm not particularly good at coming up with names ;)
build.conf is maybe not too bad considering that there may be a day where
it is extended to support "<driver>.conf" as well.


One other thing I wanted to mention but forgot was that lkc now
does a quiet "make oldconfig" when .config changed or does not exist,
which is changed behavior.

I intentionally only printed a message and errored out in this case, and I
think that's more useful, particularly for people doing

make all 2>&1 > make.log

which now may take forever waiting for input.

--Kai


2002-09-22 23:04:54

by Roman Zippel

[permalink] [raw]
Subject: Re: [kbuild-devel] linux kernel conf 0.6

Hi,

On Sun, 22 Sep 2002, Kai Germaschewski wrote:

> > One cosmetic thing I mentioned to Roman, Config.new needs to be changed
> > to something better, like conf.in or build.conf or somesuch.
>
> I agree. (But I'm not particularly good at coming up with names ;)
> build.conf is maybe not too bad considering that there may be a day where
> it is extended to support "<driver>.conf" as well.

Maybe it should start with a capital letter like Makefile/Config.in, so
it's at the top of a directory listing.

> I intentionally only printed a message and errored out in this case, and I
> think that's more useful, particularly for people doing
>
> make all 2>&1 > make.log
>
> which now may take forever waiting for input.

You should have tried this first :) :

$ make | cat
make[1]: Entering directory `/home/roman/src/linux-lkc/scripts'
make[1]: Leaving directory `/home/roman/src/linux-lkc/scripts'
make[1]: Entering directory `/home/roman/src/lc'
make[1]: `conf' is up to date.
make[1]: Leaving directory `/home/roman/src/lc'
./scripts/lkc/conf -s arch/i386/config.new
#
# using defaults found in .config
#
*
* Restart config...
*
Enable loadable module support (MODULES) [Y/n/?] y
Set version information on all module symbols (MODVERSIONS) [N/y/?] (NEW) aborted!

Console input/output is redirected. Run 'make oldconfig' to update configuration.

make: *** [include/linux/autoconf.h] Error 1

bye, Roman

2002-09-22 23:14:37

by Kai Germaschewski

[permalink] [raw]
Subject: Re: [kbuild-devel] linux kernel conf 0.6

On Mon, 23 Sep 2002, Roman Zippel wrote:

> > I intentionally only printed a message and errored out in this case, and I
> > think that's more useful, particularly for people doing
> >
> > make all 2>&1 > make.log
> >
> > which now may take forever waiting for input.
>
> You should have tried this first :) :

Yup, obviously ;) Sorry about that.

>
> $ make | cat
> make[1]: Entering directory `/home/roman/src/linux-lkc/scripts'
> make[1]: Leaving directory `/home/roman/src/linux-lkc/scripts'
> make[1]: Entering directory `/home/roman/src/lc'
> make[1]: `conf' is up to date.
> make[1]: Leaving directory `/home/roman/src/lc'
> ./scripts/lkc/conf -s arch/i386/config.new
> #
> # using defaults found in .config
> #
> *
> * Restart config...
> *
> Enable loadable module support (MODULES) [Y/n/?] y
> Set version information on all module symbols (MODVERSIONS) [N/y/?] (NEW) aborted!
>
> Console input/output is redirected. Run 'make oldconfig' to update configuration.
>
> make: *** [include/linux/autoconf.h] Error 1

I'm still not happy at least for the ".config does not exist" case. Since
when I forget to "cp ../config-2.5 .config", I don't really want "make
oldconfig", I want to do the forgotten cp. I think there's hardly anyone
who wants oldconfig in that case, rather menuconfig/xconfig or a cp like I
mentioned. Since kbuild/lkc does not know, it shouldn't make that (bad)
guess.

If .config exist but is not current, I think in 99% of the cases we really
want make oldconfig, so that's fine.

--Kai


2002-09-22 23:27:02

by Roman Zippel

[permalink] [raw]
Subject: Re: [kbuild-devel] linux kernel conf 0.6

Hi,

On Sun, 22 Sep 2002, Kai Germaschewski wrote:

> I'm still not happy at least for the ".config does not exist" case. Since
> when I forget to "cp ../config-2.5 .config", I don't really want "make
> oldconfig", I want to do the forgotten cp.

Adding this check to the silent mode is trivial.

bye, Roman