2013-04-13 14:05:49

by Axel Lin

[permalink] [raw]

Subject: [PATCH] regulator: max8997: Test pdata by NULL checking instead of IS_ERR_OR_NULL

---

pdata is either a valid pointer or NULL, use NULL checking rather than
IS_ERR_OR_NULL macro.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/regulator/max8997.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/max8997.c b/drivers/regulator/max8997.c
index 0ac7a87..df20069 100644
--- a/drivers/regulator/max8997.c
+++ b/drivers/regulator/max8997.c
@@ -1035,8 +1035,8 @@ static int max8997_pmic_probe(struct platform_device *pdev)
int i, ret, size, nr_dvs;
u8 max_buck1 = 0, max_buck2 = 0, max_buck5 = 0;

- if (IS_ERR_OR_NULL(pdata)) {
- dev_err(pdev->dev.parent, "No platform init data supplied.\n");
+ if (!pdata) {
+ dev_err(&pdev->dev, "No platform init data supplied.\n");
return -ENODEV;
}

--
1.7.10.4

2013-04-15 16:22:11

by Mark Brown

[permalink] [raw]

Subject: Re: [PATCH] regulator: max8997: Test pdata by NULL checking instead of IS_ERR_OR_NULL

---

On Sat, Apr 13, 2013 at 10:05:43PM +0800, Axel Lin wrote:
> pdata is either a valid pointer or NULL, use NULL checking rather than
> IS_ERR_OR_NULL macro.

Applied, thanks.

---

Attachments:

(No filename) (173.00 B)
signature.asc (836.00 B)
Digital signature Download all attachments