2013-04-15 20:17:18

by Michael Braun

Subject: Regression in 3735ba8db8e6ea22ad3ff524328926d8d780a884 with Freescale P1020

Hi,

I'm running OpenWRT Kernel 3.8.3 (which already has
f66dea709cd9309b2ee9f715697818001fb518de and
5ed338778f917a035f0f0a52327fc4f72e36f7a1 applied) on a P1020WLAN (QorlQ,
PPC) device.
Before updating the kernel from 3.3.0, USB host support was working
fine. Now I get "fsl-ehci: USB PHY clock invalid" messages in dmesg and
the lsusb output is empty, so USB host support is not working. When I
apply the following patch, USB host support starts working again, so I
guess 3735ba8db8e6ea22ad3ff524328926d8d780a884 is the cause.

Regards,
M. Braun

--- a/drivers/usb/host/ehci-fsl.c 2013-04-15 21:13:52.924403077
+0200
+++ b/drivers/usb/host/ehci-fsl.c 2013-04-15 21:13:57.572410838
+0200
@@ -273,7 +273,6 @@ static int ehci_fsl_setup_phy(struct usb
if (!spin_event_timeout(in_be32(non_ehci +
FSL_SOC_USB_CTRL) &
PHY_CLK_VALID, FSL_USB_PHY_CLK_TIMEOUT,
0)) {
printk(KERN_WARNING "fsl-ehci: USB PHY clock
invalid\n");
- return -EINVAL;
}
}

2013-04-16 15:35:17

by Alan Stern

Subject: Re: Regression in 3735ba8db8e6ea22ad3ff524328926d8d780a884 with Freescale P1020

On Mon, 15 Apr 2013, Michael Braun wrote:

> Hi,
>
> I'm running OpenWRT Kernel 3.8.3 (which already has
> f66dea709cd9309b2ee9f715697818001fb518de and
> 5ed338778f917a035f0f0a52327fc4f72e36f7a1 applied) on a P1020WLAN (QorlQ,
> PPC) device.
> Before updating the kernel from 3.3.0, USB host support was working
> fine. Now I get "fsl-ehci: USB PHY clock invalid" messages in dmesg and
> the lsusb output is empty, so USB host support is not working. When I
> apply the following patch, USB host support starts working again, so I
> guess 3735ba8db8e6ea22ad3ff524328926d8d780a884 is the cause.

Why didn't you CC: the author of that commit? Isn't he the person most
likely to be able to fix it?

Alan Stern