2013-04-16 11:10:23

by Lad, Prabhakar

[permalink] [raw]
Subject: [PATCH] media: davinci: vpbe: align the buffers size to page page size boundary

From: Lad, Prabhakar <[email protected]>

with recent commit with id 068a0df76023926af958a336a78bef60468d2033
which adds add length check for mmap, the application were failing to
mmap the buffers.

This patch aligns the the buffer size to page size boundary for both
capture and display driver so the it pass the check.

Signed-off-by: Lad, Prabhakar <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Hans Verkuil <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
---
drivers/media/platform/davinci/vpbe_display.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/platform/davinci/vpbe_display.c b/drivers/media/platform/davinci/vpbe_display.c
index 1802f11..ff8fe76 100644
--- a/drivers/media/platform/davinci/vpbe_display.c
+++ b/drivers/media/platform/davinci/vpbe_display.c
@@ -258,7 +258,7 @@ vpbe_buffer_queue_setup(struct vb2_queue *vq, const struct v4l2_format *fmt,
*nbuffers = layer->numbuffers = VPBE_DEFAULT_NUM_BUFS;

*nplanes = 1;
- sizes[0] = layer->pix_fmt.sizeimage;
+ sizes[0] = PAGE_ALIGN(layer->pix_fmt.sizeimage);
alloc_ctxs[0] = layer->alloc_ctx;

return 0;
--
1.7.4.1


2013-04-16 11:41:30

by Sergei Shtylyov

[permalink] [raw]
Subject: Re: [PATCH] media: davinci: vpbe: align the buffers size to page page size boundary

On 16-04-2013 15:10, Prabhakar lad wrote:

> From: Lad, Prabhakar <[email protected]>

> with recent commit with id 068a0df76023926af958a336a78bef60468d2033

Please also specify the summary line of that commit in parens (or however
you like).

> which adds add length check for mmap, the application were failing to
> mmap the buffers.

> This patch aligns the the buffer size to page size boundary for both
> capture and display driver so the it pass the check.

> Signed-off-by: Lad, Prabhakar <[email protected]>
> Cc: Laurent Pinchart <[email protected]>
> Cc: Hans Verkuil <[email protected]>
> Cc: Mauro Carvalho Chehab <[email protected]>

WBR, Sergei