2013-04-16 17:30:07

by Suman Anna

[permalink] [raw]
Subject: [PATCH 1/2] remoteproc: fix kconfig dependencies for VIRTIO

remoteproc configuration selects VIRTIO, but VIRTIO is now
subordinate to VIRTUALIZATION. VIRTUALIZATION has to be
selected as well to honor the kconfig menu hierarchy and fix
the dependency warnings.

warning: (VIRTIO_PCI && VIRTIO_MMIO && REMOTEPROC && RPMSG) selects VIRTIO which has unmet direct dependencies (VIRTUALIZATION)
warning: (VIRTIO_PCI && VIRTIO_MMIO && REMOTEPROC && RPMSG) selects VIRTIO which has unmet direct dependencies (VIRTUALIZATION)

Signed-off-by: Suman Anna <[email protected]>
---
drivers/remoteproc/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
index c6d77e2..e5f6183 100644
--- a/drivers/remoteproc/Kconfig
+++ b/drivers/remoteproc/Kconfig
@@ -5,6 +5,7 @@ config REMOTEPROC
tristate
depends on HAS_DMA
select FW_LOADER
+ select VIRTUALIZATION
select VIRTIO

config OMAP_REMOTEPROC
--
1.8.2


2013-04-18 10:51:44

by Ohad Ben-Cohen

[permalink] [raw]
Subject: Re: [PATCH 1/2] remoteproc: fix kconfig dependencies for VIRTIO

On Tue, Apr 16, 2013 at 8:25 PM, Suman Anna <[email protected]> wrote:
> remoteproc configuration selects VIRTIO, but VIRTIO is now
> subordinate to VIRTUALIZATION. VIRTUALIZATION has to be
> selected as well to honor the kconfig menu hierarchy and fix
> the dependency warnings.

Thanks Suman. Is this stable material as well or not relevant before 3.9?

2013-04-18 15:51:15

by Suman Anna

[permalink] [raw]
Subject: RE: [PATCH 1/2] remoteproc: fix kconfig dependencies for VIRTIO

>
> On Tue, Apr 16, 2013 at 8:25 PM, Suman Anna <[email protected]> wrote:
> > remoteproc configuration selects VIRTIO, but VIRTIO is now subordinate
> > to VIRTUALIZATION. VIRTUALIZATION has to be selected as well to honor
> > the kconfig menu hierarchy and fix the dependency warnings.
>
> Thanks Suman. Is this stable material as well or not relevant before 3.9?

No, it is not applicable before 3.9.

Regards
Suman

2013-04-21 13:23:13

by Ohad Ben-Cohen

[permalink] [raw]
Subject: Re: [PATCH 1/2] remoteproc: fix kconfig dependencies for VIRTIO

On Thu, Apr 18, 2013 at 6:51 PM, Anna, Suman <[email protected]> wrote:
>>
>> On Tue, Apr 16, 2013 at 8:25 PM, Suman Anna <[email protected]> wrote:
>> > remoteproc configuration selects VIRTIO, but VIRTIO is now subordinate
>> > to VIRTUALIZATION. VIRTUALIZATION has to be selected as well to honor
>> > the kconfig menu hierarchy and fix the dependency warnings.
>>
>> Thanks Suman. Is this stable material as well or not relevant before 3.9?
>
> No, it is not applicable before 3.9.

Thanks. We're already at rc7 and it's not urgent, so I plan to push
this when the merge windows opens with cc stable

2013-04-22 16:22:51

by Suman Anna

[permalink] [raw]
Subject: RE: [PATCH 1/2] remoteproc: fix kconfig dependencies for VIRTIO

> On Thu, Apr 18, 2013 at 6:51 PM, Anna, Suman <[email protected]> wrote:
> >>
> >> On Tue, Apr 16, 2013 at 8:25 PM, Suman Anna <[email protected]> wrote:
> >> > remoteproc configuration selects VIRTIO, but VIRTIO is now
> >> > subordinate to VIRTUALIZATION. VIRTUALIZATION has to be selected as
> >> > well to honor the kconfig menu hierarchy and fix the dependency warnings.
> >>
> >> Thanks Suman. Is this stable material as well or not relevant before 3.9?
> >
> > No, it is not applicable before 3.9.
>
> Thanks. We're already at rc7 and it's not urgent, so I plan to push this when the
> merge windows opens with cc stable

Thanks, I agree - it is not a critical fix.