2002-09-24 23:57:23

by Matthew Dobson

[permalink] [raw]
Subject: Re: [Lse-tech] [PATCH 1/2] node affine NUMA scheduler

Martin J. Bligh wrote:
> A few comments ... mainly just i386 arch things (which aren't
> really your fault, was just a lack of the mechanisms being in
> mainline), and a request to push a couple of things down into
> the arch trees from rearing their ugly head into generic code ;-)


>>+extern int pnode_to_lnode[NR_NODES];
>>+extern char lnode_number[NR_CPUS] __cacheline_aligned;
> Can't you push all this down into the arch ....
>>+#define CPU_TO_NODE(cpu) lnode_number[cpu]
> ... by letting them define cpu_to_node() themselves?
> (most people don't have lnodes and pnodes, etc).
Yep... Sorry to get into the thread late, but Erich, you should really
look at the latest in-kernel topology API stuff in the mm tree. I'd be
happy to discuss it with you over email... Plus, I'd get another user
of the topology (to help push it into mainline) and ia64 support, and
you'd get a generic topology mechanism that works (err, will work?) for
all architectures. Email me for more info, or just check out the patch
that Martin pointed to! :)