2013-04-17 17:15:00

by Eduardo Valentin

[permalink] [raw]
Subject: [PATCH 06/30] thermal: cpu_cooling: standardize end of function

Just for code readiness, this patch makes all functions
on this file to have a blank line before their returns.
Now, some functions follow this pattern, and others will
not have a blank line. So, this patch makes it a single
pattern.

Cc: Zhang Rui <[email protected]>
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Eduardo Valentin <[email protected]>
---
drivers/thermal/cpu_cooling.c | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
index bdc4233..68d5a2d 100644
--- a/drivers/thermal/cpu_cooling.c
+++ b/drivers/thermal/cpu_cooling.c
@@ -67,6 +67,11 @@ static struct cpufreq_cooling_device *notify_device;
* get_idr - function to get a unique id.
* @idr: struct idr * handle used to create a id.
* @id: int * value generated by this function.
+ *
+ * This function will populate @id with an unique
+ * id, using the idr API.
+ *
+ * Return: 0 on success, an error code on failure.
*/
static int get_idr(struct idr *idr, int *id)
{
@@ -78,6 +83,7 @@ static int get_idr(struct idr *idr, int *id)
if (unlikely(ret < 0))
return ret;
*id = ret;
+
return 0;
}

@@ -102,6 +108,7 @@ static void release_idr(struct idr *idr, int id)
static int is_cpufreq_valid(int cpu)
{
struct cpufreq_policy policy;
+
return !cpufreq_get_policy(&policy, cpu);
}

@@ -189,6 +196,7 @@ static int get_property(unsigned int cpu, unsigned long input,
}
j++;
}
+
return -EINVAL;
}

@@ -198,6 +206,7 @@ unsigned long cpufreq_cooling_get_level(unsigned int cpu, unsigned int freq)

if (get_property(cpu, (unsigned long)freq, &val, GET_LEVEL))
return THERMAL_CSTATE_INVALID;
+
return (unsigned long)val;
}
EXPORT_SYMBOL_GPL(cpufreq_cooling_get_level);
@@ -216,6 +225,7 @@ static unsigned int get_cpu_frequency(unsigned int cpu, unsigned long level)
ret = get_property(cpu, level, &freq, GET_FREQ);
if (ret)
return 0;
+
return freq;
}

@@ -322,6 +332,7 @@ static int cpufreq_get_cur_state(struct thermal_cooling_device *cdev,
struct cpufreq_cooling_device *cpufreq_device = cdev->devdata;

*state = cpufreq_device->cpufreq_state;
+
return 0;
}

@@ -411,6 +422,7 @@ struct thermal_cooling_device *cpufreq_cooling_register(
cpufreq_dev_count++;

mutex_unlock(&cooling_cpufreq_lock);
+
return cool_dev;
}
EXPORT_SYMBOL_GPL(cpufreq_cooling_register);
--
1.8.2.1.342.gfa7285d