2013-04-17 17:22:16

by Eduardo Valentin

Subject: [PATCH 26/30] thermal: cpu_cooling: remove unused symbols

The list is needed so far. Thus removing it.

Cc: Zhang Rui <[email protected]>
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Eduardo Valentin <[email protected]>
---
drivers/thermal/cpu_cooling.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c
index 3709274..825231f 100644
--- a/drivers/thermal/cpu_cooling.c
+++ b/drivers/thermal/cpu_cooling.c
@@ -38,11 +38,9 @@
* @cpufreq_val: integer value representing the absolute value of the clipped
* frequency.
* @allowed_cpus: all the cpus involved for this cpufreq_cooling_device.
- * @node: list_head to link all cpufreq_cooling_device together.
*
* This structure is required for keeping information of each
- * cpufreq_cooling_device registered as a list whose head is represented by
- * cooling_cpufreq_list. In order to prevent corruption of this list a
+ * cpufreq_cooling_device registered. In order to prevent corruption of this a
* mutex lock cooling_cpufreq_lock is used.
*/
struct cpufreq_cooling_device {
@@ -51,9 +49,7 @@ struct cpufreq_cooling_device {
unsigned int cpufreq_state;
unsigned int cpufreq_val;
struct cpumask allowed_cpus;
- struct list_head node;
};
-static LIST_HEAD(cooling_cpufreq_list);
static DEFINE_IDR(cpufreq_idr);
static DEFINE_MUTEX(cooling_cpufreq_lock);

--
1.8.2.1.342.gfa7285d

2013-04-24 14:52:34

by Zhang Rui

Subject: RE: [PATCH 26/30] thermal: cpu_cooling: remove unused symbols

> -----Original Message-----
> From: Eduardo Valentin [mailto:[email protected]]
> Sent: Thursday, April 18, 2013 1:12 AM
> To: [email protected]
> Cc: Eduardo Valentin; Zhang, Rui; [email protected]; linux-
> [email protected]
> Subject: [PATCH 26/30] thermal: cpu_cooling: remove unused symbols
> Importance: High
>
> The list is needed so far. Thus removing it.
>
s/needed/not needed?

Thanks,
rui
> Cc: Zhang Rui <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Eduardo Valentin <[email protected]>
> ---
> drivers/thermal/cpu_cooling.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/thermal/cpu_cooling.c
> b/drivers/thermal/cpu_cooling.c index 3709274..825231f 100644
> --- a/drivers/thermal/cpu_cooling.c
> +++ b/drivers/thermal/cpu_cooling.c
> @@ -38,11 +38,9 @@
> * @cpufreq_val: integer value representing the absolute value of the
> clipped
> * frequency.
> * @allowed_cpus: all the cpus involved for this
> cpufreq_cooling_device.
> - * @node: list_head to link all cpufreq_cooling_device together.
> *
> * This structure is required for keeping information of each
> - * cpufreq_cooling_device registered as a list whose head is
> represented by
> - * cooling_cpufreq_list. In order to prevent corruption of this list a
> + * cpufreq_cooling_device registered. In order to prevent corruption
> of
> + this a
> * mutex lock cooling_cpufreq_lock is used.
> */
> struct cpufreq_cooling_device {
> @@ -51,9 +49,7 @@ struct cpufreq_cooling_device {
> unsigned int cpufreq_state;
> unsigned int cpufreq_val;
> struct cpumask allowed_cpus;
> - struct list_head node;
> };
> -static LIST_HEAD(cooling_cpufreq_list); static
> DEFINE_IDR(cpufreq_idr); static DEFINE_MUTEX(cooling_cpufreq_lock);
>
> --
> 1.8.2.1.342.gfa7285d

2013-04-24 17:33:44

by Eduardo Valentin

Subject: Re: [PATCH 26/30] thermal: cpu_cooling: remove unused symbols

On 24-04-2013 10:52, Zhang, Rui wrote:
>
>
>> -----Original Message-----
>> From: Eduardo Valentin [mailto:[email protected]]
>> Sent: Thursday, April 18, 2013 1:12 AM
>> To: [email protected]
>> Cc: Eduardo Valentin; Zhang, Rui; [email protected]; linux-
>> [email protected]
>> Subject: [PATCH 26/30] thermal: cpu_cooling: remove unused symbols
>> Importance: High
>>
>> The list is needed so far. Thus removing it.
>>
> s/needed/not needed?
>

yes, thanks.

> Thanks,
> rui
>> Cc: Zhang Rui <[email protected]>
>> Cc: [email protected]
>> Cc: [email protected]
>> Signed-off-by: Eduardo Valentin <[email protected]>
>> ---
>> drivers/thermal/cpu_cooling.c | 6 +-----
>> 1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> diff --git a/drivers/thermal/cpu_cooling.c
>> b/drivers/thermal/cpu_cooling.c index 3709274..825231f 100644
>> --- a/drivers/thermal/cpu_cooling.c
>> +++ b/drivers/thermal/cpu_cooling.c
>> @@ -38,11 +38,9 @@
>> * @cpufreq_val: integer value representing the absolute value of the
>> clipped
>> * frequency.
>> * @allowed_cpus: all the cpus involved for this
>> cpufreq_cooling_device.
>> - * @node: list_head to link all cpufreq_cooling_device together.
>> *
>> * This structure is required for keeping information of each
>> - * cpufreq_cooling_device registered as a list whose head is
>> represented by
>> - * cooling_cpufreq_list. In order to prevent corruption of this list a
>> + * cpufreq_cooling_device registered. In order to prevent corruption
>> of
>> + this a
>> * mutex lock cooling_cpufreq_lock is used.
>> */
>> struct cpufreq_cooling_device {
>> @@ -51,9 +49,7 @@ struct cpufreq_cooling_device {
>> unsigned int cpufreq_state;
>> unsigned int cpufreq_val;
>> struct cpumask allowed_cpus;
>> - struct list_head node;
>> };
>> -static LIST_HEAD(cooling_cpufreq_list); static
>> DEFINE_IDR(cpufreq_idr); static DEFINE_MUTEX(cooling_cpufreq_lock);
>>
>> --
>> 1.8.2.1.342.gfa7285d
>
>
>