2013-04-21 03:44:49

by Andi Kleen

Subject: [PATCH] fix initconst in lib/decompress.c

From: Andi Kleen <[email protected]>


diff --git a/lib/decompress.c b/lib/decompress.c
index 31a8042..f8fdeda 100644
--- a/lib/decompress.c
+++ b/lib/decompress.c
@@ -38,7 +38,7 @@ struct compress_format {
decompress_fn decompressor;
};

-static const struct compress_format compressed_formats[] __initdata = {
+static const struct compress_format compressed_formats[] __initconst = {
{ {037, 0213}, "gzip", gunzip },
{ {037, 0236}, "gzip", gunzip },
{ {0x42, 0x5a}, "bzip2", bunzip2 },

2013-04-23 22:02:21

by Andrew Morton

Subject: Re: [PATCH] fix initconst in lib/decompress.c

On Sat, 20 Apr 2013 20:44:45 -0700 Andi Kleen <[email protected]> wrote:

> From: Andi Kleen <[email protected]>
>
>
> diff --git a/lib/decompress.c b/lib/decompress.c
> index 31a8042..f8fdeda 100644
> --- a/lib/decompress.c
> +++ b/lib/decompress.c
> @@ -38,7 +38,7 @@ struct compress_format {
> decompress_fn decompressor;
> };
>
> -static const struct compress_format compressed_formats[] __initdata = {
> +static const struct compress_format compressed_formats[] __initconst = {
> { {037, 0213}, "gzip", gunzip },
> { {037, 0236}, "gzip", gunzip },
> { {0x42, 0x5a}, "bzip2", bunzip2 },

That's missing both a changelog and the signed-off-by. Did your
scripts break?

2013-04-23 22:10:20

by Andi Kleen

Subject: Re: [PATCH] fix initconst in lib/decompress.c

On Tue, Apr 23, 2013 at 03:02:09PM -0700, Andrew Morton wrote:
> On Sat, 20 Apr 2013 20:44:45 -0700 Andi Kleen <[email protected]> wrote:
>
> > From: Andi Kleen <[email protected]>
> >
> >
> > diff --git a/lib/decompress.c b/lib/decompress.c
> > index 31a8042..f8fdeda 100644
> > --- a/lib/decompress.c
> > +++ b/lib/decompress.c
> > @@ -38,7 +38,7 @@ struct compress_format {
> > decompress_fn decompressor;
> > };
> >
> > -static const struct compress_format compressed_formats[] __initdata = {
> > +static const struct compress_format compressed_formats[] __initconst = {
> > { {037, 0213}, "gzip", gunzip },
> > { {037, 0236}, "gzip", gunzip },
> > { {0x42, 0x5a}, "bzip2", bunzip2 },
>
> That's missing both a changelog and the signed-off-by. Did your
> scripts break?

I normally don't write a description for initconst patches, as
they should be obvious.

Sorry for the missing Signed-off-by. Hereby added:

Signed-off-by: Andi Kleen <[email protected]>

Please let me know if I should resend.

-Andi

--
[email protected] -- Speaking for myself only