2013-04-29 13:40:25

by Steven Rostedt

[permalink] [raw]
Subject: [PATCH 1/2] ktest: Allow tests to use different GRUB_MENUs

From: "Steven Rostedt (Red Hat)" <[email protected]>

To save connecting and searching for a given grub menu for each test,
ktest.pl will cache the grub number it found. The problem is that
different tests might use a different grub menu, but ktest.pl will
ignore it.

Instead, have ktest.pl check if the grub menu it used to cache the
content is the same as when it grabbed the menu. If not, grab it again,
otherwise just return the cached value.

Signed-off-by: Steven Rostedt <[email protected]>
---
tools/testing/ktest/ktest.pl | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
index 4e67d52..7958cd4 100755
--- a/tools/testing/ktest/ktest.pl
+++ b/tools/testing/ktest/ktest.pl
@@ -108,6 +108,7 @@ my $scp_to_target;
my $scp_to_target_install;
my $power_off;
my $grub_menu;
+my $last_grub_menu;
my $grub_file;
my $grub_number;
my $grub_reboot;
@@ -1538,7 +1539,8 @@ sub run_scp_mod {

sub get_grub2_index {

- return if (defined($grub_number));
+ return if (defined($grub_number) && defined($last_grub_menu) &&
+ $last_grub_menu eq $grub_menu);

doprint "Find grub2 menu ... ";
$grub_number = -1;
@@ -1565,6 +1567,7 @@ sub get_grub2_index {
die "Could not find '$grub_menu' in $grub_file on $machine"
if (!$found);
doprint "$grub_number\n";
+ $last_grub_menu = $grub_menu;
}

sub get_grub_index {
@@ -1577,7 +1580,8 @@ sub get_grub_index {
if ($reboot_type ne "grub") {
return;
}
- return if (defined($grub_number));
+ return if (defined($grub_number) && defined($last_grub_menu) &&
+ $last_grub_menu eq $grub_menu);

doprint "Find grub menu ... ";
$grub_number = -1;
@@ -1604,6 +1608,7 @@ sub get_grub_index {
die "Could not find '$grub_menu' in /boot/grub/menu on $machine"
if (!$found);
doprint "$grub_number\n";
+ $last_grub_menu = $grub_menu;
}

sub wait_for_input
--
1.7.10.4



Attachments:
signature.asc (490.00 B)
This is a digitally signed message part