2002-09-29 12:41:03

by Oleg Nesterov

Subject: [UPATCH] force_sig_info()

Hello.

This is my third attempt:

On Mon, 16 Sep 2002, Oleg Nesterov wrote:
> 2.5.34 introduced this change in force_sig_info()
>
> - return send_sig_info(sig, info, t);
> + return send_sig_info(sig, (void *)1, t);
>
> I beleive, it is wrong, info can carry useful information
> from do_page_fault, traps. And this (info *)1 does not
> prevent send_signal() from allocation of siginfo struct.
> Ingo, could you please clarify?

Call me stupid, but i still believe it is bug.

--- linux-2.5.39/kernel/signal.c~ Sun Sep 29 16:37:08 2002
+++ linux-2.5.39/kernel/signal.c Sun Sep 29 16:37:35 2002
@@ -781,7 +781,7 @@
recalc_sigpending_tsk(t);
spin_unlock_irqrestore(&t->sigmask_lock, flags);

- return send_sig_info(sig, (void *)1, t);
+ return send_sig_info(sig, info, t);
}

static int

Oleg.

2002-09-29 12:56:04

by Oleg Nesterov

Subject: Re: [UPATCH] force_sig_info()

Hello.

Just browsed marc.theaimsgroup.com, it is fixed already.
Sorry for noise.

Oleg.