2002-10-01 19:10:10

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH] Re: Shared memory shmat/dt not working well in

Hugh Dickins wrote:
>
> ...
> --- 2.5.40/mm/mprotect.c Fri Sep 27 23:56:45 2002
> +++ linux/mm/mprotect.c Tue Oct 1 18:00:31 2002
> @@ -186,8 +186,10 @@
> /*
> * Try to merge with the previous vma.
> */
> - if (mprotect_attempt_merge(vma, *pprev, end, newflags))
> + if (mprotect_attempt_merge(vma, *pprev, end, newflags)) {
> + vma = *pprev;
> goto success;
> + }
> } else {
> error = split_vma(mm, vma, start, 1);
> if (error)

Got that, thanks.

I think that's enough "cleanups" for 2.5, guys. Let's concentrate
on missing must-have functionality, bugs and tuning from now.