2002-10-04 05:42:06

by Suresh Siddha

[permalink] [raw]
Subject: cs4281 driver fix

Patch below fixes a oops problem (in cs4281 sound driver) during system
reboot.

thanks,
suresh

diff -Nru linux-2.5.39/sound/oss/cs4281/cs4281m.c~
linux-2.5.39/sound/oss/cs4281/cs4281m.c
--- linux-2.5.39/sound/oss/cs4281/cs4281m.c~ Thu Oct 3 20:56:19 2002
+++ linux-2.5.39/sound/oss/cs4281/cs4281m.c Thu Oct 3 22:33:16 2002
@@ -4437,7 +4437,7 @@

// ---------------------------------------------------------------------

-static void __devinit cs4281_remove(struct pci_dev *pci_dev)
+static void __devexit cs4281_remove(struct pci_dev *pci_dev)
{
struct cs4281_state *s = pci_get_drvdata(pci_dev);
// stop DMA controller
@@ -4467,7 +4467,7 @@
name:"cs4281",
id_table:cs4281_pci_tbl,
probe:cs4281_probe,
- remove:cs4281_remove,
+ remove:__devexit_p(cs4281_remove),
suspend:CS4281_SUSPEND_TBL,
resume:CS4281_RESUME_TBL,
};


2002-10-07 15:08:31

by Woller, Thomas

[permalink] [raw]
Subject: RE: cs4281 driver fix

thanks for the patch. i've been out having baby #2 but back on
email now.

i have not been up on recent 2.5.x mods but the modification
looks simple and other audio drivers have the same modifications.
applying the fix to the 2.5.41(?) tree seems safe. i'll send your
patch to the 2.5.x audio responsible person, but not sure whom it
is? (i don't *think* it's alan). also the cs46xx driver will
need the same mod which i'll create and send this week.
tom woller
[email protected]

-----Original Message-----
From: Siddha, Suresh B [mailto:[email protected]]
Sent: Friday, October 04, 2002 12:48 AM
To: '[email protected]'; '[email protected]';
'[email protected]'
Subject: cs4281 driver fix


Patch below fixes a oops problem (in cs4281 sound driver) during
system
reboot.

thanks,
suresh

diff -Nru linux-2.5.39/sound/oss/cs4281/cs4281m.c~
linux-2.5.39/sound/oss/cs4281/cs4281m.c
--- linux-2.5.39/sound/oss/cs4281/cs4281m.c~ Thu Oct 3
20:56:19 2002
+++ linux-2.5.39/sound/oss/cs4281/cs4281m.c Thu Oct 3
22:33:16 2002
@@ -4437,7 +4437,7 @@

//
-----------------------------------------------------------------
----

-static void __devinit cs4281_remove(struct pci_dev *pci_dev)
+static void __devexit cs4281_remove(struct pci_dev *pci_dev)
{
struct cs4281_state *s = pci_get_drvdata(pci_dev);
// stop DMA controller
@@ -4467,7 +4467,7 @@
name:"cs4281",
id_table:cs4281_pci_tbl,
probe:cs4281_probe,
- remove:cs4281_remove,
+ remove:__devexit_p(cs4281_remove),
suspend:CS4281_SUSPEND_TBL,
resume:CS4281_RESUME_TBL,
};

2002-10-07 15:26:55

by Alan Cox

[permalink] [raw]
Subject: RE: cs4281 driver fix

For 2.5 Linus is the best person, but if you cc me I can collect it up
too