2002-10-08 19:40:55

by Alan Cox

[permalink] [raw]
Subject: PATCH: fix imm compile

diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.2.5.41/drivers/scsi/imm.c linux.2.5.41-ac1/drivers/scsi/imm.c
--- linux.2.5.41/drivers/scsi/imm.c 2002-10-07 22:12:25.000000000 +0100
+++ linux.2.5.41-ac1/drivers/scsi/imm.c 2002-10-08 00:53:06.000000000 +0100
@@ -27,8 +27,10 @@
#include <linux/blk.h>
#include <asm/io.h>
#include <linux/parport.h>
+#include <linux/workqueue.h>
#include "sd.h"
#include "hosts.h"
+
typedef struct {
struct pardevice *dev; /* Parport device entry */
int base; /* Actual port address */
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.2.5.41/drivers/scsi/imm.h linux.2.5.41-ac1/drivers/scsi/imm.h
--- linux.2.5.41/drivers/scsi/imm.h 2002-10-02 21:32:55.000000000 +0100
+++ linux.2.5.41-ac1/drivers/scsi/imm.h 2002-10-08 00:53:12.000000000 +0100
@@ -71,7 +71,6 @@
#include <linux/stddef.h>
#include <linux/module.h>
#include <linux/kernel.h>
-#include <linux/tqueue.h>
#include <linux/ioport.h>
#include <linux/delay.h>
#include <linux/proc_fs.h>


2002-10-08 19:56:59

by Ankit

[permalink] [raw]
Subject: Re: PATCH: fix imm compile

iam using this driver to fetch me some memory in
my user space application by calling mmap with the
file descriptor got by opening the device file for
this driver.
mmap(0, length, flags, flags, fd, offset)

and the mmap entry point in the driver is implemented
as below:

In the implementation, it tries to write an index into
the first four bytes, which i use to store in my
internal structures( to later reference it through the
index), before zeroing out the buffer. But the index
is always -1.

I dont understand the part where its getting the
physical address to map.
whats the high_memory and whats the PAGE_OFFSET.
Can you help me in understanding what exactly is the
mmap() doing here and
if its doing it right.


himem_buf_allocated = 0;

int xxx_mmap(struct file *filp,
struct vm_area_struct *vma)
{
unsigned long size;
char * virt_addr;
int index;

size = vma->vm_end - vma->vm_start;
if ((size % PAGE_SIZE) != 0){
size = (size / PAGE_SIZE) * PAGE_SIZE + PAGE_SIZE;
}

/* himem_buf_size is 0x80000000 */
if (size + himem_buf_allocated >= himem_buf_size){

return -ENOMEM;
}

/* himem_buf is calculated as high_memory -
PAGE_OFFSET */
umem_addr = himem_buf + himem_buf_allocated;
if (umem_addr == 0){
return -ENOMEM;
}
himem_buf_allocated += size;


virt_addr = ioremap((unsigned long)umem_addr,
PAGE_SIZE);
if (virt_addr == 0){
return -ENOMEM;
}
/* write the index into the first 4 bytes */
writel(index, (uint32_t *)virt_addr);

/* the values of index and *(virt_addr) do not
match. *(virt_addr) is always -1 .
Is something wrong here */
dbg_printf(0,"index is %d, *(virt_addr) is %d\n",
index,(int)readl(virt_addr));
iounmap(virt_addr);



remap_page_range(vma->vm_start, (ulong)umem_addr,
vma->vm_end - vma->vm_start, vma->vm_page_prot);

return 0;
}


__________________________________________________
Do you Yahoo!?
Faith Hill - Exclusive Performances, Videos & More
http://faith.yahoo.com