2014-02-21 19:54:47

by Geert Uytterhoeven

Subject: [PATCH] mtd: nand: MTD_NAND_SH_FLCTL should depend on HAS_DMA

If NO_DMA=y:

drivers/built-in.o: In function `flctl_dma_fifo0_transfer':
sh_flctl.c:(.text+0x210398): undefined reference to `dma_map_single'
sh_flctl.c:(.text+0x2104b0): undefined reference to `dma_unmap_single'

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/mtd/nand/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
index 90ff447bf043..e7786913280a 100644
--- a/drivers/mtd/nand/Kconfig
+++ b/drivers/mtd/nand/Kconfig
@@ -458,6 +458,7 @@ config MTD_NAND_MXC

config MTD_NAND_SH_FLCTL
tristate "Support for NAND on Renesas SuperH FLCTL"
+ depends on HAS_DMA
depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
help
Several Renesas SuperH CPU has FLCTL. This option enables support
--
1.7.9.5

2014-02-21 20:26:16

by Laurent Pinchart

Subject: Re: [PATCH] mtd: nand: MTD_NAND_SH_FLCTL should depend on HAS_DMA

Hi Geert,

Thank you for the patch.

On Friday 21 February 2014 20:54:34 Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
> drivers/built-in.o: In function `flctl_dma_fifo0_transfer':
> sh_flctl.c:(.text+0x210398): undefined reference to `dma_map_single'
> sh_flctl.c:(.text+0x2104b0): undefined reference to `dma_unmap_single'
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Acked-by: Laurent Pinchart <[email protected]>

> ---
> drivers/mtd/nand/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index 90ff447bf043..e7786913280a 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -458,6 +458,7 @@ config MTD_NAND_MXC
>
> config MTD_NAND_SH_FLCTL
> tristate "Support for NAND on Renesas SuperH FLCTL"
> + depends on HAS_DMA
> depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
> help
> Several Renesas SuperH CPU has FLCTL. This option enables support

--
Regards,

Laurent Pinchart

2014-02-21 20:49:19

by Brian Norris

Subject: Re: [PATCH] mtd: nand: MTD_NAND_SH_FLCTL should depend on HAS_DMA

Hi Geert,

On Fri, Feb 21, 2014 at 09:27:27PM +0100, Laurent Pinchart wrote:
> On Friday 21 February 2014 20:54:34 Geert Uytterhoeven wrote:
> > If NO_DMA=y:
> >
> > drivers/built-in.o: In function `flctl_dma_fifo0_transfer':
> > sh_flctl.c:(.text+0x210398): undefined reference to `dma_map_single'
> > sh_flctl.c:(.text+0x2104b0): undefined reference to `dma_unmap_single'
> >
> > Signed-off-by: Geert Uytterhoeven <[email protected]>
>
> Acked-by: Laurent Pinchart <[email protected]>
>
> > ---
> > drivers/mtd/nand/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> > index 90ff447bf043..e7786913280a 100644
> > --- a/drivers/mtd/nand/Kconfig
> > +++ b/drivers/mtd/nand/Kconfig
> > @@ -458,6 +458,7 @@ config MTD_NAND_MXC
> >
> > config MTD_NAND_SH_FLCTL
> > tristate "Support for NAND on Renesas SuperH FLCTL"
> > + depends on HAS_DMA
> > depends on SUPERH || ARCH_SHMOBILE || COMPILE_TEST
> > help
> > Several Renesas SuperH CPU has FLCTL. This option enables support

It looks like Richard beat you to this. I have a similar patch queued up
in l2-mtd.git:

commit 4c8a074b3abab5a5d77c9a19f2fa5fb9d50f9908
Author: Richard Weinberger <[email protected]>
Date: Fri Jan 31 13:39:07 2014 +0100

mtd: nand: flctl: Add dependency on HAS_IOMEM and HAS_DMA

Thanks,
Brian