2014-07-25 22:03:06

by Mark Salter

[permalink] [raw]
Subject: [PATCH v2] perf: fix arm64 build error

I'm seeing the following build error on arm64:

In file included from util/event.c:3:0:
util/event.h:95:17: error: 'PERF_REGS_MAX' undeclared here (not in a function)
u64 cache_regs[PERF_REGS_MAX];
^

This patch adds a PERF_REGS_MAX definition for arm64.

Signed-off-by: Mark Salter <[email protected]>
Acked-by: Jean Pihet <[email protected]>
---
tools/perf/arch/arm64/include/perf_regs.h | 2 ++
1 file changed, 2 insertions(+)

diff --git a/tools/perf/arch/arm64/include/perf_regs.h b/tools/perf/arch/arm64/include/perf_regs.h
index e9441b9..1d3f39c 100644
--- a/tools/perf/arch/arm64/include/perf_regs.h
+++ b/tools/perf/arch/arm64/include/perf_regs.h
@@ -6,6 +6,8 @@
#include <asm/perf_regs.h>

#define PERF_REGS_MASK ((1ULL << PERF_REG_ARM64_MAX) - 1)
+#define PERF_REGS_MAX PERF_REG_ARM64_MAX
+
#define PERF_REG_IP PERF_REG_ARM64_PC
#define PERF_REG_SP PERF_REG_ARM64_SP

--
1.9.0


2014-07-26 14:55:13

by Arnaldo Carvalho de Melo

[permalink] [raw]
Subject: Re: [PATCH v2] perf: fix arm64 build error

Em Fri, Jul 25, 2014 at 06:02:46PM -0400, Mark Salter escreveu:
> I'm seeing the following build error on arm64:
>
> In file included from util/event.c:3:0:
> util/event.h:95:17: error: 'PERF_REGS_MAX' undeclared here (not in a function)
> u64 cache_regs[PERF_REGS_MAX];
> ^
>
> This patch adds a PERF_REGS_MAX definition for arm64.
>
> Signed-off-by: Mark Salter <[email protected]>
> Acked-by: Jean Pihet <[email protected]>

Thanks, applied to my perf/core branch.

- Arnaldo