2015-07-17 07:23:51

by Sudip Mukherjee

[permalink] [raw]
Subject: [PATCH] ASoC: rt5645: remove unused variable

We were getting a build warning about unused variable. This variable was
a leftover from:
a4e3c5fa955c ("ASoC: rt5645: Simplify rt5645_enable_push_button_irq")

Signed-off-by: Sudip Mukherjee <[email protected]>
---
sound/soc/codecs/rt5645.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c
index d24c979..ff091d6 100644
--- a/sound/soc/codecs/rt5645.c
+++ b/sound/soc/codecs/rt5645.c
@@ -2763,7 +2763,6 @@ static void rt5645_enable_push_button_irq(struct snd_soc_codec *codec,
bool enable)
{
struct snd_soc_dapm_context *dapm = snd_soc_codec_get_dapm(codec);
- struct rt5645_priv *rt5645 = snd_soc_codec_get_drvdata(codec);

if (enable) {
snd_soc_dapm_force_enable_pin(dapm, "ADC L power");
--
1.8.1.2


2015-07-17 08:07:40

by Nicolas Boichat

[permalink] [raw]
Subject: Re: [alsa-devel] [PATCH] ASoC: rt5645: remove unused variable

On Fri, Jul 17, 2015 at 3:23 PM, Sudip Mukherjee
<[email protected]> wrote:
> We were getting a build warning about unused variable. This variable was
> a leftover from:
> a4e3c5fa955c ("ASoC: rt5645: Simplify rt5645_enable_push_button_irq")

Yes, I already sent a patch to fix it:
https://patchwork.kernel.org/patch/6812261/ .

Thanks.

> Signed-off-by: Sudip Mukherjee <[email protected]>
> ---
> sound/soc/codecs/rt5645.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c
> index d24c979..ff091d6 100644
> --- a/sound/soc/codecs/rt5645.c
> +++ b/sound/soc/codecs/rt5645.c
> @@ -2763,7 +2763,6 @@ static void rt5645_enable_push_button_irq(struct snd_soc_codec *codec,
> bool enable)
> {
> struct snd_soc_dapm_context *dapm = snd_soc_codec_get_dapm(codec);
> - struct rt5645_priv *rt5645 = snd_soc_codec_get_drvdata(codec);
>
> if (enable) {
> snd_soc_dapm_force_enable_pin(dapm, "ADC L power");
> --
> 1.8.1.2
>
> _______________________________________________
> Alsa-devel mailing list
> [email protected]
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel