2001-02-17 19:03:11

by Just Marc

Subject: [PATCH] APMD on Linux 2.2.18 and include/linux/mc146818rtc.h

I've noticed this when attempting to build APMD, mc146818rtc.h has
a reference to a spinlock_t while asm/spinlock.h is not included.

Patch follows:

--- linux-2.2.18.orig/include/linux/mc146818rtc.h Fri Jan 12 19:15:00 2001
+++ linux-2.2.18/include/linux/mc146818rtc.h Tue Feb 20 01:17:09 2001
@@ -11,6 +11,7 @@
#ifndef _MC146818RTC_H
#define _MC146818RTC_H
#include <asm/io.h>
+#include <asm/spinlock.h>

#ifndef RTC_PORT
#define RTC_PORT(x) (0x70 + (x))


bye,
Marc.

--
marc @ corky.net

fingerprint = D1F0 5689 967F B87A 98EB C64D 256A D6BF 80DE 6D3C

/"\
\ / ASCII Ribbon Campaign
X Against HTML Mail
/ \

2001-02-19 08:05:56

by Paul Gortmaker

Subject: Re: [PATCH] APMD on Linux 2.2.18 and include/linux/mc146818rtc.h

Marc Esipovich wrote:
>
> I've noticed this when attempting to build APMD, mc146818rtc.h has
> a reference to a spinlock_t while asm/spinlock.h is not included.
>
> Patch follows:

User space does not need to ever see any kernel spinlocks - you will find
such a fix for this is in 2.2.19pre already though, so you can make use
of that.

Thanks for the report anyway,
Paul.


_________________________________________________________
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com