2015-12-22 15:42:49

by Jan Beulich

[permalink] [raw]
Subject: [PATCH] x86/LDT: fix a log message

This was meant to print base address and entry count; make it do so
again.

Signed-off-by: Jan Beulich <[email protected]>
---
arch/x86/kernel/process_64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- 4.4-rc6/arch/x86/kernel/process_64.c
+++ 4.4-rc6-x86-LDT-message/arch/x86/kernel/process_64.c
@@ -125,7 +125,7 @@ void release_thread(struct task_struct *
if (dead_task->mm->context.ldt) {
pr_warn("WARNING: dead process %s still has LDT? <%p/%d>\n",
dead_task->comm,
- dead_task->mm->context.ldt,
+ dead_task->mm->context.ldt->entries,
dead_task->mm->context.ldt->size);
BUG();
}



2015-12-22 22:50:25

by Andy Lutomirski

[permalink] [raw]
Subject: Re: [PATCH] x86/LDT: fix a log message

On Tue, Dec 22, 2015 at 7:42 AM, Jan Beulich <[email protected]> wrote:
> This was meant to print base address and entry count; make it do so
> again.

Acked-by: Andy Lutomirski <[email protected]>

Lesson of the day: I should have renamed that variable.

--Andy

>
> Signed-off-by: Jan Beulich <[email protected]>
> ---
> arch/x86/kernel/process_64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- 4.4-rc6/arch/x86/kernel/process_64.c
> +++ 4.4-rc6-x86-LDT-message/arch/x86/kernel/process_64.c
> @@ -125,7 +125,7 @@ void release_thread(struct task_struct *
> if (dead_task->mm->context.ldt) {
> pr_warn("WARNING: dead process %s still has LDT? <%p/%d>\n",
> dead_task->comm,
> - dead_task->mm->context.ldt,
> + dead_task->mm->context.ldt->entries,
> dead_task->mm->context.ldt->size);
> BUG();
> }
>
>
>



--
Andy Lutomirski
AMA Capital Management, LLC

Subject: [tip:x86/mm] x86/LDT: Print the real LDT base address

Commit-ID: 0d430e3fb3f7cdc13c0d22078b820f682821b45a
Gitweb: http://git.kernel.org/tip/0d430e3fb3f7cdc13c0d22078b820f682821b45a
Author: Jan Beulich <[email protected]>
AuthorDate: Tue, 22 Dec 2015 08:42:44 -0700
Committer: Thomas Gleixner <[email protected]>
CommitDate: Tue, 29 Dec 2015 12:34:38 +0100

x86/LDT: Print the real LDT base address

This was meant to print base address and entry count; make it do so
again.

Fixes: 37868fe113ff "x86/ldt: Make modify_ldt synchronous"
Signed-off-by: Jan Beulich <[email protected]>
Acked-by: Andy Lutomirski <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Thomas Gleixner <[email protected]>
---
arch/x86/kernel/process_64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/process_64.c b/arch/x86/kernel/process_64.c
index e835d26..b9d99e0 100644
--- a/arch/x86/kernel/process_64.c
+++ b/arch/x86/kernel/process_64.c
@@ -125,7 +125,7 @@ void release_thread(struct task_struct *dead_task)
if (dead_task->mm->context.ldt) {
pr_warn("WARNING: dead process %s still has LDT? <%p/%d>\n",
dead_task->comm,
- dead_task->mm->context.ldt,
+ dead_task->mm->context.ldt->entries,
dead_task->mm->context.ldt->size);
BUG();
}