x86-generic in 2.5.72 does not compile, because
include/asm-i386/mach-generic/mach_apic.h does not define
enable_apic_mode(). Although I kludged around this, by
just defining enable_apic_mode() as nothing (since it is
apparently nothing for all x86 platforms except es7000),
I imagine that the correct definition is
#define enable_apic_mode (genapic->enable_apic_mode)
...along with some other changes to declare
genapic->enable_apic_mode and initialize it for each platform
type.
Adam J. Richter __ ______________ 575 Oroville Road
[email protected] \ / Miplitas, California 95035
+1 408 309-6081 | g g d r a s i l United States of America
"Free Software For The Rest Of Us."
On Wed, Jun 18, 2003 at 01:27:55AM -0700, Adam J. Richter wrote:
> x86-generic in 2.5.72 does not compile, because
> include/asm-i386/mach-generic/mach_apic.h does not define
> enable_apic_mode(). Although I kludged around this, by
> just defining enable_apic_mode() as nothing (since it is
> apparently nothing for all x86 platforms except es7000),
> I imagine that the correct definition is
>
> #define enable_apic_mode (genapic->enable_apic_mode)
>
> ...along with some other changes to declare
> genapic->enable_apic_mode and initialize it for each platform
> type.
It should be enough to add it to the genapic structure in
asm-i386/genapic.h and also to the APIC_INIT macro in the same file.
(assuming that it is properly defined for default,bigsmp,summit)
-Andi
Andi Kleen <[email protected]> wrote:
>
> It should be enough to add it to the genapic structure in
> asm-i386/genapic.h and also to the APIC_INIT macro in the same file.
Works for me.
> (assuming that it is properly defined for default,bigsmp,summit)
Seems to be.
diff -puN include/asm-i386/mach-generic/mach_apic.h~mach-generic-build-fix include/asm-i386/mach-generic/mach_apic.h
--- 25/include/asm-i386/mach-generic/mach_apic.h~mach-generic-build-fix 2003-06-18 02:06:07.000000000 -0700
+++ 25-akpm/include/asm-i386/mach-generic/mach_apic.h 2003-06-18 02:06:07.000000000 -0700
@@ -25,5 +25,6 @@
#define check_phys_apicid_present (genapic->check_phys_apicid_present)
#define check_apicid_used (genapic->check_apicid_used)
#define cpu_mask_to_apicid (genapic->cpu_mask_to_apicid)
+#define enable_apic_mode (genapic->enable_apic_mode)
#endif /* __ASM_MACH_APIC_H */
diff -puN include/asm-i386/genapic.h~mach-generic-build-fix include/asm-i386/genapic.h
--- 25/include/asm-i386/genapic.h~mach-generic-build-fix 2003-06-18 02:06:07.000000000 -0700
+++ 25-akpm/include/asm-i386/genapic.h 2003-06-18 02:06:07.000000000 -0700
@@ -43,6 +43,7 @@ struct genapic {
struct mpc_config_translation *t);
void (*setup_portio_remap)(void);
int (*check_phys_apicid_present)(int boot_cpu_physical_apicid);
+ void (*enable_apic_mode)(void);
/* mpparse */
void (*mpc_oem_bus_info)(struct mpc_config_bus *, char *,
@@ -101,6 +102,7 @@ struct genapic {
APICFUNC(send_IPI_mask), \
APICFUNC(send_IPI_allbutself), \
APICFUNC(send_IPI_all), \
+ APICFUNC(enable_apic_mode), \
}
extern struct genapic *genapic;
_