2017-07-31 20:11:43

by John Johansen

[permalink] [raw]
Subject: Re: security/apparmor/label.c:1498]: (style) Redundant condition

On 07/17/2017 12:34 AM, David Binderman wrote:
> Hello there,
>
>
> security/apparmor/label.c:1498]: (style) Redundant condition: prev_ns. '!prev_ns || (prev_ns && *prev_ns!=profile->ns)' is equivalent to '!prev_ns || *prev_ns!=profile->ns'
>
> Source code is
>
> if (view != profile->ns &&
> (!prev_ns || (prev_ns && *prev_ns != profile->ns))) {
>

yep, I will add the fix to the next pull request