2017-08-25 13:11:02

by Bhumika Goyal

Subject: [PATCH] s390/zcrypt: make CPRBX const

Make this const as it is only used in a copy operation.

Signed-off-by: Bhumika Goyal <[email protected]>
---
drivers/s390/crypto/zcrypt_msgtype6.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/s390/crypto/zcrypt_msgtype6.c b/drivers/s390/crypto/zcrypt_msgtype6.c
index 4fddb43..afd20ce 100644
--- a/drivers/s390/crypto/zcrypt_msgtype6.c
+++ b/drivers/s390/crypto/zcrypt_msgtype6.c
@@ -140,7 +140,7 @@ struct function_and_rules_block {
* + 0x000A 'MRP ' (MCL3 'PK' or CEX2C 'PK')
* - VUD block
*/
-static struct CPRBX static_cprbx = {
+static const struct CPRBX static_cprbx = {
.cprb_len = 0x00DC,
.cprb_ver_id = 0x02,
.func_id = {0x54, 0x32},
--
1.9.1

2017-08-28 06:37:35

by Harald Freudenberger

Subject: Re: [PATCH] s390/zcrypt: make CPRBX const

On 08/25/2017 03:10 PM, Bhumika Goyal wrote:
> Make this const as it is only used in a copy operation.
>
> Signed-off-by: Bhumika Goyal <[email protected]>
> ---
> drivers/s390/crypto/zcrypt_msgtype6.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/s390/crypto/zcrypt_msgtype6.c b/drivers/s390/crypto/zcrypt_msgtype6.c
> index 4fddb43..afd20ce 100644
> --- a/drivers/s390/crypto/zcrypt_msgtype6.c
> +++ b/drivers/s390/crypto/zcrypt_msgtype6.c
> @@ -140,7 +140,7 @@ struct function_and_rules_block {
> * + 0x000A 'MRP ' (MCL3 'PK' or CEX2C 'PK')
> * - VUD block
> */
> -static struct CPRBX static_cprbx = {
> +static const struct CPRBX static_cprbx = {
> .cprb_len = 0x00DC,
> .cprb_ver_id = 0x02,
> .func_id = {0x54, 0x32},
Applied. Will be available with the next merge.
Thanks and have a nice day.

Harald Freudenberger