2017-12-01 10:43:45

by Matthias Brugger

Subject: [PATCH 1/2] thermal: mtk: Cleanup unused defines

The mtk_thermal has some defiens which are never used within the driver.
This patch delets them.

Signed-off-by: Matthias Brugger <[email protected]>
---
drivers/thermal/mtk_thermal.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
index 1e61c09153c9..c75661a3801a 100644
--- a/drivers/thermal/mtk_thermal.c
+++ b/drivers/thermal/mtk_thermal.c
@@ -32,15 +32,10 @@
#include <linux/types.h>

/* AUXADC Registers */
-#define AUXADC_CON0_V 0x000
-#define AUXADC_CON1_V 0x004
#define AUXADC_CON1_SET_V 0x008
#define AUXADC_CON1_CLR_V 0x00c
#define AUXADC_CON2_V 0x010
#define AUXADC_DATA(channel) (0x14 + (channel) * 4)
-#define AUXADC_MISC_V 0x094
-
-#define AUXADC_CON1_CHANNEL(x) BIT(x)

#define APMIXED_SYS_TS_CON1 0x604

@@ -158,8 +153,6 @@
/* The number of sensing points per bank */
#define MT2712_NUM_SENSORS_PER_ZONE 4

-#define THERMAL_NAME "mtk-thermal"
-
struct mtk_thermal;

struct thermal_bank_cfg {
@@ -765,7 +758,7 @@ static struct platform_driver mtk_thermal_driver = {
.probe = mtk_thermal_probe,
.remove = mtk_thermal_remove,
.driver = {
- .name = THERMAL_NAME,
+ .name = "mtk-thermal",
.of_match_table = mtk_thermal_of_match,
},
};
--
2.12.3

2017-12-14 11:21:39

by Matthias Brugger

Subject: Re: [PATCH 1/2] thermal: mtk: Cleanup unused defines

On 12/01/2017 11:43 AM, Matthias Brugger wrote:
> The mtk_thermal has some defiens which are never used within the driver.
> This patch delets them.
>
> Signed-off-by: Matthias Brugger <[email protected]>
> ---
> drivers/thermal/mtk_thermal.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
> index 1e61c09153c9..c75661a3801a 100644
> --- a/drivers/thermal/mtk_thermal.c
> +++ b/drivers/thermal/mtk_thermal.c
> @@ -32,15 +32,10 @@
> #include <linux/types.h>
>
> /* AUXADC Registers */
> -#define AUXADC_CON0_V 0x000
> -#define AUXADC_CON1_V 0x004
> #define AUXADC_CON1_SET_V 0x008
> #define AUXADC_CON1_CLR_V 0x00c
> #define AUXADC_CON2_V 0x010
> #define AUXADC_DATA(channel) (0x14 + (channel) * 4)
> -#define AUXADC_MISC_V 0x094
> -
> -#define AUXADC_CON1_CHANNEL(x) BIT(x)
>
> #define APMIXED_SYS_TS_CON1 0x604
>
> @@ -158,8 +153,6 @@
> /* The number of sensing points per bank */
> #define MT2712_NUM_SENSORS_PER_ZONE 4
>
> -#define THERMAL_NAME "mtk-thermal"
> -
> struct mtk_thermal;
>
> struct thermal_bank_cfg {
> @@ -765,7 +758,7 @@ static struct platform_driver mtk_thermal_driver = {
> .probe = mtk_thermal_probe,
> .remove = mtk_thermal_remove,
> .driver = {
> - .name = THERMAL_NAME,
> + .name = "mtk-thermal",
> .of_match_table = mtk_thermal_of_match,
> },
> };
>

Kind ping.

2017-12-14 11:26:19

by Daniel Lezcano

Subject: Re: [PATCH 1/2] thermal: mtk: Cleanup unused defines

On 01/12/2017 11:43, Matthias Brugger wrote:
> The mtk_thermal has some defiens which are never used within the driver.
> This patch delets them.
>
> Signed-off-by: Matthias Brugger <[email protected]>

Acked-by: Daniel Lezcano <[email protected]>




--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

2017-12-21 10:01:25

by Matthias Brugger

Subject: Re: [PATCH 1/2] thermal: mtk: Cleanup unused defines

On 12/01/2017 11:43 AM, Matthias Brugger wrote:
> The mtk_thermal has some defiens which are never used within the driver.
> This patch delets them.
>
> Signed-off-by: Matthias Brugger <[email protected]>
> ---

Rui, Eduardo, do you have any comments on this patch?

Regards,
Matthias

> drivers/thermal/mtk_thermal.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
> index 1e61c09153c9..c75661a3801a 100644
> --- a/drivers/thermal/mtk_thermal.c
> +++ b/drivers/thermal/mtk_thermal.c
> @@ -32,15 +32,10 @@
> #include <linux/types.h>
>
> /* AUXADC Registers */
> -#define AUXADC_CON0_V 0x000
> -#define AUXADC_CON1_V 0x004
> #define AUXADC_CON1_SET_V 0x008
> #define AUXADC_CON1_CLR_V 0x00c
> #define AUXADC_CON2_V 0x010
> #define AUXADC_DATA(channel) (0x14 + (channel) * 4)
> -#define AUXADC_MISC_V 0x094
> -
> -#define AUXADC_CON1_CHANNEL(x) BIT(x)
>
> #define APMIXED_SYS_TS_CON1 0x604
>
> @@ -158,8 +153,6 @@
> /* The number of sensing points per bank */
> #define MT2712_NUM_SENSORS_PER_ZONE 4
>
> -#define THERMAL_NAME "mtk-thermal"
> -
> struct mtk_thermal;
>
> struct thermal_bank_cfg {
> @@ -765,7 +758,7 @@ static struct platform_driver mtk_thermal_driver = {
> .probe = mtk_thermal_probe,
> .remove = mtk_thermal_remove,
> .driver = {
> - .name = THERMAL_NAME,
> + .name = "mtk-thermal",
> .of_match_table = mtk_thermal_of_match,
> },
> };
>

2017-12-21 13:40:20

by Zhang, Rui

Subject: Re: [PATCH 1/2] thermal: mtk: Cleanup unused defines

On Thu, 2017-12-21 at 11:01 +0100, Matthias Brugger wrote:
>
> On 12/01/2017 11:43 AM, Matthias Brugger wrote:
> >
> > The mtk_thermal has some defiens which are never used within the
> > driver.
> > This patch delets them.
> >
> > Signed-off-by: Matthias Brugger <[email protected]>
> > ---
> Rui, Eduardo, do you have any comments on this patch?
>
No, I don't have any.
I suppose Eduardo will review them soon as I need the thermal soc
material for next merge window.

thanks,
rui
> Regards,
> Matthias
>
> >
> >  drivers/thermal/mtk_thermal.c | 9 +--------
> >  1 file changed, 1 insertion(+), 8 deletions(-)
> >
> > diff --git a/drivers/thermal/mtk_thermal.c
> > b/drivers/thermal/mtk_thermal.c
> > index 1e61c09153c9..c75661a3801a 100644
> > --- a/drivers/thermal/mtk_thermal.c
> > +++ b/drivers/thermal/mtk_thermal.c
> > @@ -32,15 +32,10 @@
> >  #include <linux/types.h>
> >  
> >  /* AUXADC Registers */
> > -#define AUXADC_CON0_V 0x000
> > -#define AUXADC_CON1_V 0x004
> >  #define AUXADC_CON1_SET_V 0x008
> >  #define AUXADC_CON1_CLR_V 0x00c
> >  #define AUXADC_CON2_V 0x010
> >  #define AUXADC_DATA(channel) (0x14 + (channel) * 4)
> > -#define AUXADC_MISC_V 0x094
> > -
> > -#define AUXADC_CON1_CHANNEL(x) BIT(x)
> >  
> >  #define APMIXED_SYS_TS_CON1 0x604
> >  
> > @@ -158,8 +153,6 @@
> >  /* The number of sensing points per bank */
> >  #define MT2712_NUM_SENSORS_PER_ZONE 4
> >  
> > -#define THERMAL_NAME    "mtk-thermal"
> > -
> >  struct mtk_thermal;
> >  
> >  struct thermal_bank_cfg {
> > @@ -765,7 +758,7 @@ static struct platform_driver
> > mtk_thermal_driver = {
> >   .probe = mtk_thermal_probe,
> >   .remove = mtk_thermal_remove,
> >   .driver = {
> > - .name = THERMAL_NAME,
> > + .name = "mtk-thermal",
> >   .of_match_table = mtk_thermal_of_match,
> >   },
> >  };
> >

2018-01-01 19:56:58

by Eduardo Valentin

Subject: Re: [PATCH 1/2] thermal: mtk: Cleanup unused defines

On Thu, Dec 21, 2017 at 09:40:13PM +0800, Zhang Rui wrote:
> On Thu, 2017-12-21 at 11:01 +0100, Matthias Brugger wrote:
> >
> > On 12/01/2017 11:43 AM, Matthias Brugger wrote:
> > >
> > > The mtk_thermal has some defiens which are never used within the
> > > driver.
> > > This patch delets them.
> > >
> > > Signed-off-by: Matthias Brugger <[email protected]>
> > > ---
> > Rui, Eduardo, do you have any comments on this patch?
> >
> No, I don't have any.
> I suppose Eduardo will review them soon as I need the thermal soc
> material for next merge window.

Yeah, I will be queueing this soon.